Skip to content

hw/net: Make Net/CanBus can_receive() handlers return a boolean

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 16 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6hw/net/e1000e_core: Let e1000e_can_receive() return a booleanhw/net/e1000e_core.c hw/net/e1000e_core.h+2 -23 replies
2/6hw/net/smc91c111: Let smc91c111_can_receive() return a booleanhw/net/smc91c111.c+4 -42 replies
3/6hw/net/rtl8139: Simplify if/else statementhw/net/rtl8139.c+4 -42 replies
4/6hw/net/rtl8139: Update coding style to make checkpatch.pl happyhw/net/rtl8139.c+6 -42 replies
5/6hw/net: Make NetCanReceive() return a booleanhw/net/allwinner_emac.c hw/net/cadence_gem.c hw/net/dp8393x.c +17 more+45 -483 replies
6/6hw/net/can: Make CanBusClientInfo::can_receive() return a booleanhw/net/can/can_sja1000.c hw/net/can/can_sja1000.h include/net/can_emu.h +1 more+8 -82 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisDavid GibsonPaolo BonziniCédric Le Goater
1/6R-b R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b A-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean

The Net/CanBus can_receive() handlers return whether the network device can or can not receive new data. Make it obvious by returning a boolean type

Philippe Mathieu-Daudé (6):
hw/net/e1000e_core: Let e1000e_can_receive() return a boolean hw/net/smc91c111: Let smc91c111_can_receive() return a boolean hw/net/rtl8139: Simplify if/else statement hw/net/rtl8139: Update coding style to make checkpatch.pl happy hw/net: Make NetCanReceive() return a boolean hw/net/can: Make CanBusClientInfo::can_receive() return a boolean

 hw/net/can/can_sja1000.h |  2 +-
 hw/net/e1000e_core.h     |  2 +-
 hw/net/i82596.h          |  2 +-
 include/net/can_emu.h    |  2 +-
 include/net/net.h        |  2 +-
 hw/net/allwinner_emac.c  |  2 +-
 hw/net/cadence_gem.c     |  8 ++++----
 hw/net/can/can_sja1000.c |  8 ++++----
 hw/net/dp8393x.c         |  8 +++-----
 hw/net/e1000.c           |  2 +-
 hw/net/e1000e.c          |  2 +-
 hw/net/e1000e_core.c     |  2 +-
 hw/net/ftgmac100.c       |  6 +++---
 hw/net/i82596.c          | 10 +++++-----
 hw/net/imx_fec.c         |  2 +-
 hw/net/opencores_eth.c   |  5 ++---
 hw/net/rtl8139.c         | 22 ++++++++++++----------
 hw/net/smc91c111.c       | 10 +++++-----
 hw/net/spapr_llan.c      |  4 ++--
 hw/net/sungem.c          |  6 +++---
 hw/net/sunhme.c          |  4 ++--
 hw/net/virtio-net.c      | 10 +++++-----
 hw/net/xilinx_ethlite.c  |  2 +-
 net/can/can_socketcan.c  |  4 ++--
 net/filter-buffer.c      |  2 +-
 net/hub.c                |  6 +++---
 26 files changed, 67 insertions(+), 68 deletions(-)
Signature · 1 line
2.21.1