Skip to content

libmpathpersist allocation size fixes

[email protected] dm-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- 02/04: fix overflow calculation (Ben)
- 04/04: improve commit description wrt ABI breakage

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4libmpathpersist: limit PRIN allocation length to 8192 byteslibmpathpersist/mpath_pr_ioctl.c+2 -00 replies
2/4libmpathpersist: format_transportids(): avoid PROUT overflowlibmpathpersist/mpath_pr_ioctl.c+29 -21 reply
3/4libmpathpersist: mpath_format_readfullstatus(): use real buffer sizelibmpathpersist/mpath_pr_ioctl.c+8 -40 replies
4/4libmpathpersist: ABI change: limit data-in/out size to 8192 byteslibmpathpersist/mpath_persist.h+11 -41 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
1/4R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] [PATCH 0/4] libmpathpersist allocation size fixes

From: Martin Wilck <[email protected]>

Hi Christophe,

We recently found a problem with mpathpersist using an allocation length of > 8192 bytes for PERSISTENT RESERVE IN/OUT commands. This patch set tries to fix it. The last patch would change the ABI for external programs, it's optional.

(Christophe, to avoid misunderstanding: This set is not meant to be included
in the upcoming merge).

Reviews and comments welcome.

Changes in v2:
- 02/04: fix overflow calculation (Ben)
- 04/04: improve commit description wrt ABI breakage

Martin Wilck (4):
libmpathpersist: limit PRIN allocation length to 8192 bytes
libmpathpersist: format_transportids(): avoid PROUT overflow
libmpathpersist: mpath_format_readfullstatus(): use real buffer size
libmpathpersist: ABI change: limit data-in/out size to 8192 bytes

 libmpathpersist/mpath_persist.h  | 15 ++++++++---
 libmpathpersist/mpath_pr_ioctl.c | 45 +++++++++++++++++++++++++++-----
 2 files changed, 50 insertions(+), 10 deletions(-)

--

2.25.1