Skip to content

x86/kvm: Sanitize async page fault

Thomas Gleixner kvm lkml oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/kvm: Handle async page faults directly through do_page_fault()arch/x86/entry/entry_32.S arch/x86/entry/entry_64.S arch/x86/include/asm/kvm_para.h +5 more+57 -370 replies
2/2x86/kvm: Sanitize kvm_async_pf_task_wait()arch/x86/include/asm/kvm_para.h arch/x86/kernel/kvm.c arch/x86/kvm/mmu/mmu.c+115 -4512 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/2] x86/kvm: Sanitize async page fault

Hi!

This emerged from the ongoing efforts to consolidate the entry code maze on x86 along with the tracing and instrumentation induced violations of RCU constraints.

While working on this I stumbled over the KVM async page fault handler and kvm_async_pf_task_wait() in particular. It took me a while to realize that the randomly sprinkled around rcu_irq_enter()/exit() invocations are just cargo cult programming. Several patches "fixed" RCU splats by curing the symptoms without realizing that the code is fundametally flawed from a design perspective.

Aside of that Andy noticed that the way the async page fault handler is implemented can be improved which in turn allows further simplification vs. CR2 consistency and the general exception entry handling on x86.

I'm sending this out as a stand alone series against mainline, but I'd prefer to take this along with the rest if the entry code rework.

If you look at the changelog then don't be afraid, most of the added lines are comments which were painfully absent in the original code.

Thanks,

tglx

---
 entry/entry_32.S       |    8 --
 entry/entry_64.S       |    4 -
 include/asm/kvm_para.h |   21 ++++-
 include/asm/x86_init.h |    2 
 kernel/kvm.c           |  193 +++++++++++++++++++++++++++++++++----------------
 kernel/traps.c         |    2 
 kernel/x86_init.c      |    1 
 kvm/mmu/mmu.c          |    2 
 mm/fault.c             |   19 ++++
 9 files changed, 171 insertions(+), 81 deletions(-)