Skip to content

hw/core/loader: Prohibit loading ROMs bigger than memory region

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/sparc64/niagara: Pass available memory region size to add_rom_or_failhw/sparc64/niagara.c+10 -70 replies
2/5hw/core/loader: Prohibit loading ROMs bigger than memory regionhw/core/loader.c+4 -12 replies
3/5hw/core/loader: Provide rom_add_file() a 'max_size' argumenthw/core/loader.c include/hw/loader.h+19 -121 reply
4/5hw/core/loader: Restrict rom_add_file_mr() to available region sizeinclude/hw/loader.h+1 -10 replies
5/5hw/core/loader: Provide rom_add_file_fixed() a 'max_size' argumenthw/i386/x86.c hw/ppc/sam460ex.c hw/sparc64/niagara.c +1 more+7 -61 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchDavid Gibson
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] hw/core/loader: Prohibit loading ROMs bigger than memory region

This series fixes a bug where an user can load ROMs bigger than the expected size. The bug is delayed after a reset where rom_reset() can overflow the underlying memory regions.

Philippe Mathieu-Daudé (5):
hw/sparc64/niagara: Pass available memory region size to
add_rom_or_fail
hw/core/loader: Prohibit loading ROMs bigger than memory region hw/core/loader: Provide rom_add_file() a 'max_size' argument hw/core/loader: Restrict rom_add_file_mr() to available region size hw/core/loader: Provide rom_add_file_fixed() a 'max_size' argument

 include/hw/loader.h  | 12 ++++++------
 hw/core/loader.c     | 24 +++++++++++++++++-------
 hw/i386/x86.c        |  2 +-
 hw/ppc/sam460ex.c    |  2 +-
 hw/sparc64/niagara.c | 22 +++++++++++++---------
 5 files changed, 38 insertions(+), 24 deletions(-)
Signature · 1 line
2.21.1