Skip to content

Add Enhanced Connection Established (ECE)

Leon Romanovsky linux-nvme linux-rdma lkml netdev oe-kbuild-all target-devel 3 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesApplied
  2. v27 patches 11 repliesSuperseded
  3. v111 patches 11 repliesApplied

Changes in v3 from the cover letter

* Rebased on top of ebd6e96b33a2 RDMA/ipoib: Remove can_sleep parameter from iboib_mcast_alloc
* Updated rdma_reject patch to include newly added RTR ulp
* Remove empty hunks added by rebase
* Changed signature of rdma_reject so kernel users will provide reason by themselves
* Squashed UAPI patch to other patches which add functionality
* Removed define of the IBTA reason from UAPI
v2: https://lore.kernel.org/linux-rdma/[email protected]/
* Rebased on latest rdma-next and removed already accepted patches.
* Updated all rdma_reject in-kernel users to provide reject reason.
v1: Dropped field_avail patch in favor of mass conversion to use function
which already exists in the kernel code.
https://lore.kernel.org/lkml/[email protected]
v0: https://lore.kernel.org/lkml/[email protected]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/cm: Add Enhanced Connection Establishment (ECE) bitsinclude/rdma/ibta_vol1_c12.h+6 -00 replies
2/6RDMA/ucma: Extend ucma_connect to receive ECE parametersdrivers/infiniband/core/cma.c drivers/infiniband/core/cma_priv.h drivers/infiniband/core/ucma.c +2 more+42 -30 replies
3/6RDMA/ucma: Deliver ECE parameters through UCMA eventsdrivers/infiniband/core/ucma.c include/rdma/rdma_cm.h include/uapi/rdma/rdma_user_cm.h+7 -10 replies
4/6RDMA/cm: Send and receive ECE parameter over the wiredrivers/infiniband/core/cm.c drivers/infiniband/core/cma.c include/rdma/ib_cm.h+50 -60 replies
5/6RDMA/cma: Connect ECE to rdma_acceptdrivers/infiniband/core/cma.c drivers/infiniband/core/ucma.c include/rdma/rdma_cm.h +1 more+34 -30 replies
6/6RDMA/cma: Provide ECE reject reasondrivers/infiniband/core/cma.c drivers/infiniband/core/ucma.c drivers/infiniband/ulp/isert/ib_isert.c +6 more+31 -142 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH rdma-next v3 0/6] Add Enhanced Connection Established (ECE)

From: Leon Romanovsky <[email protected]>

Changelog:
v3:
* Rebased on top of ebd6e96b33a2 RDMA/ipoib: Remove can_sleep parameter from iboib_mcast_alloc
* Updated rdma_reject patch to include newly added RTR ulp
* Remove empty hunks added by rebase
* Changed signature of rdma_reject so kernel users will provide reason by themselves
* Squashed UAPI patch to other patches which add functionality
* Removed define of the IBTA reason from UAPI
v2: https://lore.kernel.org/linux-rdma/[email protected]/
* Rebased on latest rdma-next and removed already accepted patches.
* Updated all rdma_reject in-kernel users to provide reject reason.
v1: Dropped field_avail patch in favor of mass conversion to use function
which already exists in the kernel code.
https://lore.kernel.org/lkml/[email protected]
v0: https://lore.kernel.org/lkml/[email protected]

Enhanced Connection Established or ECE is new negotiation scheme introduced in IBTA v1.4 to exchange extra information about nodes capabilities and later negotiate them at the connection establishment phase.

The RDMA-CM messages (REQ, REP, SIDR_REQ and SIDR_REP) were extended to carry two fields, one new and another gained new functionality:
* VendorID is a new field that indicates that common subset of vendor option bits are supported as indicated by that VendorID.
* AttributeModifier already exists, but overloaded to indicate which vendor options are supported by this VendorID.

This is kernel part of such functionality which is responsible to get data from librdmacm and properly create and handle RDMA-CM messages.

Thanks

Leon Romanovsky (6):
RDMA/cm: Add Enhanced Connection Establishment (ECE) bits RDMA/ucma: Extend ucma_connect to receive ECE parameters RDMA/ucma: Deliver ECE parameters through UCMA events RDMA/cm: Send and receive ECE parameter over the wire RDMA/cma: Connect ECE to rdma_accept
RDMA/cma: Provide ECE reject reason

 drivers/infiniband/core/cm.c            | 39 ++++++++++++++---
 drivers/infiniband/core/cma.c           | 57 ++++++++++++++++++++++---
 drivers/infiniband/core/cma_priv.h      |  1 +
 drivers/infiniband/core/ucma.c          | 49 +++++++++++++++++----
 drivers/infiniband/ulp/isert/ib_isert.c |  4 +-
 drivers/infiniband/ulp/rtrs/rtrs-srv.c  |  2 +-
 drivers/infiniband/ulp/srpt/ib_srpt.c   |  3 +-
 drivers/nvme/target/rdma.c              |  3 +-
 include/rdma/ib_cm.h                    |  9 +++-
 include/rdma/ibta_vol1_c12.h            |  6 +++
 include/rdma/rdma_cm.h                  |  9 +++-
 include/uapi/rdma/rdma_user_cm.h        | 11 ++++-
 net/rds/ib_cm.c                         |  4 +-
 13 files changed, 170 insertions(+), 27 deletions(-)

--
2.26.2