module autoloading fixes and cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 5 repliesIn review 1 of 5 applied
- v35 patches 6 repliesSuperseded
- v24 patches 9 repliesSuperseded 2 of 4 applied
Changes in v4 from the cover letter
- Added Fixes tag to the fs/filesystems.c patch, and mentioned why the warning is continued to be printed once only.
Patches in v4 1 of 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | kmod: make request_module() return an error when autoloading is disabledkernel/ | +2 | 0 replies | |
| 2/5 | fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()fs/ | +3 | 0 replies | |
| 3/5 | docs: admin-guide: document the kernel.modprobe sysctlDocumentation/ | +24 | 1 reply | |
| 4/5 | selftests: kmod: fix handling test numbers above 9tools/ | +9 | 0 replies | Applied |
| 5/5 | selftests: kmod: test disabling module autoloadingtools/ | +30 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Luis Chamberlain | Jessica Yu | Kees Cook |
|---|---|---|---|
| 1/5 | A-b | R-b | R-b |
| 2/5 | A-b | R-b | |
| 3/5 | |||
| 4/5 | A-b | ||
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/5] module autoloading fixes and cleanups
This series fixes a bug where request_module() was reporting success to kernel code when module autoloading had been completely disabled via 'echo > /proc/sys/kernel/modprobe'.
It also addresses the issues raised on the original thread
(https://lkml.kernel.org/lkml/[email protected]/T/#u)
by documenting the modprobe sysctl, adding a self-test for the empty path case, and downgrading a user-reachable WARN_ONCE().
Changed since v3:
- Added Fixes tag to the fs/filesystems.c patch, and mentioned why the warning is continued to be printed once only.
Changed since v2:
- Adjusted the new documentation to avoid implicitly bringing up module aliases, which are a more complex topic.
- Split the selftest patch into two patches, one to fix the test numbering bug and one to add the new tests.
Changed since v1:
- Added patches to address the other issues raised on the thread.
Eric Biggers (5):
kmod: make request_module() return an error when autoloading is
disabled
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to
pr_warn_once()
docs: admin-guide: document the kernel.modprobe sysctl
selftests: kmod: fix handling test numbers above 9
selftests: kmod: test disabling module autoloading
Documentation/admin-guide/sysctl/kernel.rst | 25 +++++++++++- fs/filesystems.c | 4 +- kernel/kmod.c | 4 +- tools/testing/selftests/kmod/kmod.sh | 43 +++++++++++++++++++-- 4 files changed, 68 insertions(+), 8 deletions(-)
base-commit: 5076190daded2197f62fe92cf69674488be44175
Signature · 1 line
2.25.1