Skip to content

hantro: set of small cleanups and fixes

Ezequiel Garcia linux-devicetree linux-media linux-rockchip lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 4 repliesIn review
  2. v28 patches 6 repliesSuperseded
  3. v16 patches 3 repliesSuperseded

Changes in v3 from the cover letter

* Rebased media master.

* Revert buffer sequence removal change.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7v4l2-mem2mem: return CAPTURE buffer firstdrivers/media/v4l2-core/v4l2-mem2mem.c+10 -10 replies
2/7hantro: Set buffers' zeroth plane payload in .buf_preparedrivers/staging/media/hantro/hantro_v4l2.c+11 -50 replies
3/7hantro: Use v4l2_m2m_buf_done_and_job_finishdrivers/staging/media/hantro/hantro_drv.c+9 -90 replies
4/7hantro: Remove unneeded hantro_dec_buf_finishdrivers/staging/media/hantro/hantro_drv.c+0 -100 replies
5/7hantro: Move H264 motion vector calculation to a helperdrivers/staging/media/hantro/hantro.h drivers/staging/media/hantro/hantro_hw.h drivers/staging/media/hantro/hantro_v4l2.c+33 -270 replies
6/7hantro: Refactor for V4L2 API spec compliancydrivers/staging/media/hantro/hantro.h drivers/staging/media/hantro/hantro_v4l2.c+47 -260 replies
7/7dt-bindings: rockchip-vpu: Convert bindings to json-schemaDocumentation/devicetree/bindings/media/rockchip-vpu.txt Documentation/devicetree/bindings/media/rockchip-vpu.yaml MAINTAINERS+83 -4412 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchNicolas DufresneRob Herring
1/7T-b
2/7
3/7
4/7
5/7
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] hantro: set of small cleanups and fixes

Hi all,

Cleanups and fixes, third iteration.

The main idea here is to address two issues, and while at it, clean the driver a bit.

The first issue can be found in Patch 1, when the Request API is used, the CAPTURE buffer should be returned _before_ the OUTPUT buffer, to avoid waking up userspace prematurely.

I noticed this issue while working on the rkvdec driver, but this time I've decided to tackle it at the core, in v4l2_m2m_buf_done_and_job_finish().

The second issue is a simple compliance issue, which is solved by refactoring the driver, dealing with internal set format properly.

Note that patch 7 still needs reviews from device tree maintainers.

Changes v3:

* Rebased media master.

* Revert buffer sequence removal change.

Changes v2:

* Fix compile warning introduced by patch 6.

* I'm adding two additional patches this time.
Patch 7 converts the binding to json-schema,
and patch 8 puts linux-rockchip mailing list in MAINTAINERS.

Thanks,
Ezequiel

Ezequiel Garcia (7):
v4l2-mem2mem: return CAPTURE buffer first
hantro: Set buffers' zeroth plane payload in .buf_prepare
hantro: Use v4l2_m2m_buf_done_and_job_finish
hantro: Remove unneeded hantro_dec_buf_finish
hantro: Move H264 motion vector calculation to a helper
hantro: Refactor for V4L2 API spec compliancy
dt-bindings: rockchip-vpu: Convert bindings to json-schema

 .../bindings/media/rockchip-vpu.txt           |  43 -------
 .../bindings/media/rockchip-vpu.yaml          |  82 +++++++++++++
 MAINTAINERS                                   |   2 +-
 drivers/media/v4l2-core/v4l2-mem2mem.c        |  11 +-
 drivers/staging/media/hantro/hantro.h         |   7 +-
 drivers/staging/media/hantro/hantro_drv.c     |  28 ++---
 drivers/staging/media/hantro/hantro_hw.h      |  31 +++++
 drivers/staging/media/hantro/hantro_v4l2.c    | 111 +++++++++---------
 8 files changed, 193 insertions(+), 122 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/rockchip-vpu.txt
 create mode 100644 Documentation/devicetree/bindings/media/rockchip-vpu.yaml
Signature · 1 line
2.26.0.rc2