Skip to content

rtw88: TX path update for latency and efficiency

[email protected] linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rtw88: don't hold all IRQs disabled for PS operationsdrivers/net/wireless/realtek/rtw88/pci.c drivers/net/wireless/realtek/rtw88/pci.h+36 -221 reply
2/5rtw88: extract alloc rsvd_page and h2c skb routinesdrivers/net/wireless/realtek/rtw88/pci.c drivers/net/wireless/realtek/rtw88/tx.c drivers/net/wireless/realtek/rtw88/tx.h+66 -230 replies
3/5rtw88: associate reserved pages with each vifdrivers/net/wireless/realtek/rtw88/fw.c drivers/net/wireless/realtek/rtw88/fw.h drivers/net/wireless/realtek/rtw88/mac80211.c +3 more+258 -1030 replies
4/5rtw88: pci: define a mask for TX/RX BD indexesdrivers/net/wireless/realtek/rtw88/pci.c drivers/net/wireless/realtek/rtw88/pci.h+23 -110 replies
5/5rtw88: kick off TX packets once for higher efficiencydrivers/net/wireless/realtek/rtw88/hci.h drivers/net/wireless/realtek/rtw88/pci.c drivers/net/wireless/realtek/rtw88/pci.h +2 more+136 -560 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] rtw88: TX path update for latency and efficiency

From: Yan-Hsuan Chuang <[email protected]>

This patchset makes the driver transmit with less CPU latency and higher efficiency. Originally, the TX path hold an IRQ lock that will disable all of the IRQs, to wait for the PS state transition. It may sometimes cause the CPU to delay for a long enough time, like several milliseconds. This could lead to some time-sensitive programs to lose their immediacy. We can just use *_bh() locks to not to block the IRQs, and only use *_irqsafe() locks to the ISR related settings.

And, the TX path includes to send reserved pages to the device. But the old reserved page routine did not consider that the driver could possibly run multiple vifs at the same time. So, update the reserved page routine of the TX path to generate reserved pages and associate them to each vif, so we can take multi-vif into consideration.

For the data packets come from TX queue, the driver used to kick off them one by one, while we can do better to kick a bunch of them at once to save some time to access to the IO register and the DMA engine transition

Brian Norris (1):
rtw88: don't hold all IRQs disabled for PS operations

Yan-Hsuan Chuang (4):
rtw88: extract alloc rsvd_page and h2c skb routines
rtw88: associate reserved pages with each vif
rtw88: pci: define a mask for TX/RX BD indexes
rtw88: kick off TX packets once for higher efficiency

 drivers/net/wireless/realtek/rtw88/fw.c       | 265 ++++++++++++++----
 drivers/net/wireless/realtek/rtw88/fw.h       |  25 +-
 drivers/net/wireless/realtek/rtw88/hci.h      |  20 +-
 drivers/net/wireless/realtek/rtw88/mac80211.c |  22 +-
 drivers/net/wireless/realtek/rtw88/main.c     |   9 +-
 drivers/net/wireless/realtek/rtw88/main.h     |   1 +
 drivers/net/wireless/realtek/rtw88/pci.c      | 199 ++++++++-----
 drivers/net/wireless/realtek/rtw88/pci.h      |   7 +-
 drivers/net/wireless/realtek/rtw88/tx.c       | 131 +++++++--
 drivers/net/wireless/realtek/rtw88/tx.h       |  10 +-
 drivers/net/wireless/realtek/rtw88/wow.c      |  39 +--
 11 files changed, 516 insertions(+), 212 deletions(-)
Signature · 1 line
2.17.1