Skip to content

fix & merge block_status_above and is_allocated_above

Vladimir Sementsov-Ogievskiy qemu-devel 7 versions – Applied

Status from this message: Thanks, applied to my block tree with Eric's spelling fixes:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest5 patches 5 repliesApplied
  2. v65 patches 8 repliesSuperseded
  3. v55 patches 11 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches2 repliesSuperseded
v35 patches6 repliesSuperseded
v25 patches10 repliesSuperseded
v11 patch3 repliesApplied

Changes in v7 from the cover letter

- add Alberto's r-bs in all patchs
- rebase to new backing-chain handling, bdrv_filter_or_cow_bs is used instead of backing_bs

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/5block/io: fix bdrv_co_block_status_aboveblock/io.c block/qcow2.c+68 -161 reply
2/5block/io: bdrv_common_block_status_above: support include_baseblock/coroutines.h block/io.c+16 -71 reply
3/5block/io: bdrv_common_block_status_above: support bs == baseblock/io.c+5 -10 replies
4/5block/io: fix bdrv_is_allocated_aboveblock/io.c+5 -381 reply
5/5iotests: add commit top->base cases to 274tests/qemu-iotests/274 tests/qemu-iotests/274.out+88 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAlberto GarciaEric BlakeKevin Wolf
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/5] fix & merge block_status_above and is_allocated_above

Hi all!

These series are here to address the following problem:
block-status-above functions may consider space after EOF of intermediate backing files as unallocated, which is wrong, as these backing files are the reason of producing zeroes, we never go further by backing chain after a short backing file. So, if such short-backing file is _inside_ requested sub-chain of the backing chain, we should never report space after its EOF as unallocated.

See patches 01,04,05 for details.

Note, that this series leaves for another day the general problem around block-status: misuse of BDRV_BLOCK_ALLOCATED as is-fs-allocated vs go-to-backing.
Audit for this problem is done here:
"backing chain & block status & filters"
https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html
And I'm going to prepare series to address this problem.

Also, get_block_status func have same disease, but remains unfixed here:
I want to make separate series for it.

v7:
- add Alberto's r-bs in all patchs
- rebase to new backing-chain handling, bdrv_filter_or_cow_bs is used instead of backing_bs

Based on series "[PATCH v9 0/7] coroutines: generate wrapper code" or in other words:
Based-on: <[email protected]>

Vladimir Sementsov-Ogievskiy (5):
block/io: fix bdrv_co_block_status_above
block/io: bdrv_common_block_status_above: support include_base block/io: bdrv_common_block_status_above: support bs == base block/io: fix bdrv_is_allocated_above
iotests: add commit top->base cases to 274

 block/coroutines.h         |   2 +
 block/io.c                 | 132 +++++++++++++++++++++----------------
 block/qcow2.c              |  16 ++++-
 tests/qemu-iotests/274     |  20 ++++++
 tests/qemu-iotests/274.out |  68 +++++++++++++++++++
 5 files changed, 179 insertions(+), 59 deletions(-)
Signature · 1 line
2.21.3