Skip to content

ionic support for firmware upgrade

Shannon Nelson netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyIn review
  2. v17 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ionic: decouple link message from netdev statedrivers/net/ethernet/pensando/ionic/ionic_lif.c+18 -140 replies
2/8ionic: check for linkup in watchdogdrivers/net/ethernet/pensando/ionic/ionic_dev.c drivers/net/ethernet/pensando/ionic/ionic_lif.c drivers/net/ethernet/pensando/ionic/ionic_lif.h+7 -20 replies
3/8ionic: move debugfs add/delete to match alloc/freedrivers/net/ethernet/pensando/ionic/ionic_lif.c+8 -120 replies
4/8ionic: move irq request to qcq allocdrivers/net/ethernet/pensando/ionic/ionic_lif.c+19 -220 replies
5/8ionic: clean tx queue of unfinished requestsdrivers/net/ethernet/pensando/ionic/ionic_lif.c drivers/net/ethernet/pensando/ionic/ionic_txrx.c drivers/net/ethernet/pensando/ionic/ionic_txrx.h+18 -00 replies
6/8ionic: check for queues before deletingdrivers/net/ethernet/pensando/ionic/ionic_lif.c+38 -190 replies
7/8ionic: disable the queues on link downdrivers/net/ethernet/pensando/ionic/ionic_lif.c+61 -560 replies
8/8ionic: remove lifs on fw resetdrivers/net/ethernet/pensando/ionic/ionic_dev.c drivers/net/ethernet/pensando/ionic/ionic_dev.h drivers/net/ethernet/pensando/ionic/ionic_lif.c +2 more+158 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/8] ionic support for firmware upgrade

The Pensando Distributed Services Card can get firmware upgrades from the off-host centralized management suite, and can be upgraded without a host reboot or driver reload. This patchset sets up the support for fw upgrade in the Linux driver.

When the upgrade begins, the DSC first brings the link down, then stops the firmware. The driver will notice this and quiesce itself by stopping the queues and releasing DMA resources, then monitoring for firmware to start back up. When the upgrade is finished the firmware is restarted and link is brought up, and the driver rebuilds the queues and restarts traffic flow.

First we separate the Link state from the netdev state, then reorganize a few things to prepare for partial tear-down of the queues. Next we fix up the state machine so that we take the Tx and Rx queues down and back up when we get LINK_DOWN and LINK_UP events. Lastly, we add handling of the FW reset itself by tearing down the lif internals and rebuilding them with the new FW setup.

v2: This changes the design from (ab)using the full .ndo_stop and
.ndo_open routines to getting a better separation between the alloc and the init functions so that we can keep our resource allocations as long as possible.

Shannon Nelson (8):
ionic: decouple link message from netdev state
ionic: check for linkup in watchdog
ionic: move debugfs add/delete to match alloc/free
ionic: move irq request to qcq alloc
ionic: clean tx queue of unfinished requests
ionic: check for queues before deleting
ionic: disable the queues on link down
ionic: remove lifs on fw reset

 .../net/ethernet/pensando/ionic/ionic_dev.c   |  46 ++-
 .../net/ethernet/pensando/ionic/ionic_dev.h   |   1 +
 .../net/ethernet/pensando/ionic/ionic_lif.c   | 390 +++++++++++-------
 .../net/ethernet/pensando/ionic/ionic_lif.h   |   5 +
 .../net/ethernet/pensando/ionic/ionic_main.c  |   8 +-
 .../net/ethernet/pensando/ionic/ionic_txrx.c  |  16 +
 .../net/ethernet/pensando/ionic/ionic_txrx.h  |   1 +
 7 files changed, 322 insertions(+), 145 deletions(-)
Signature · 1 line
2.17.1