Skip to content

nVMX: Clean up __enter_guest() and co.

Sean Christopherson kvm 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8nVMX: Eliminate superfluous entry_failure_handler() wrapperx86/vmx.c+3 -160 replies
2/8nVMX: Refactor VM-Entry "failure" struct into "result"x86/vmx.c x86/vmx.h x86/vmx_tests.c+112 -792 replies
3/8nVMX: Consolidate non-canonical code in test_canonical()x86/vmx_tests.c+17 -230 replies
4/8nVMX: Drop redundant check for guest terminationx86/vmx.c+0 -100 replies
5/8nVMX: Expose __enter_guest() and consolidate guest state test codex86/vmx.c x86/vmx.h x86/vmx_tests.c+40 -920 replies
6/8nVMX: Pass exit reason union to v1 exit handlersx86/vmx.c x86/vmx.h x86/vmx_tests.c+88 -1150 replies
7/8nVMX: Pass exit reason union to is_hypercall()x86/vmx.c+7 -120 replies
8/8nVMX: Pass exit reason enum to print_vmexit_info()x86/vmx.c x86/vmx.h x86/vmx_tests.c+28 -290 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [kvm-unit-tests PATCH 0/8] nVMX: Clean up __enter_guest() and co.

Start chipping away at the crustiness in the nVMX tests by refactoring "struct vmentry_failure" into "struct vmentry_result", with the full VM-Exit stored in vmentry_result. Capturing the exit reason allows for a variety of cleanups and consolidations.

This series really only dives into the v1 tests. I'd like to also clean up the v2 tests, e.g. take the expected exit reason in enter_guest() so that the expected behavior is more obvious, but that's a more invasive cleanup for another day.

Sean Christopherson (8):
nVMX: Eliminate superfluous entry_failure_handler() wrapper
nVMX: Refactor VM-Entry "failure" struct into "result"
nVMX: Consolidate non-canonical code in test_canonical()
nVMX: Drop redundant check for guest termination
nVMX: Expose __enter_guest() and consolidate guest state test code
nVMX: Pass exit reason union to v1 exit handlers
nVMX: Pass exit reason union to is_hypercall()
nVMX: Pass exit reason enum to print_vmexit_info()

 x86/vmx.c       | 191 +++++++++++--------------
 x86/vmx.h       |  50 +++++--
 x86/vmx_tests.c | 366 +++++++++++++++++++-----------------------------
 3 files changed, 263 insertions(+), 344 deletions(-)
Signature · 1 line
2.24.1