Skip to content

RFC relax barriers for ENA PMD and small fixes

Gavin Hu dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/ena: remove duplicate barrierdrivers/net/ena/base/ena_eth_com.h+1 -10 replies
2/7net/ena: relax the barrier for doorbell ringdrivers/net/ena/ena_ethdev.c+3 -30 replies
3/7net/ena: relax the rmb for DMAdrivers/net/ena/base/ena_plat_dpdk.h+1 -10 replies
4/7net/ena: relax barrier for completion queue updatedrivers/net/ena/base/ena_eth_com.h+3 -10 replies
5/7net/ena: relax the barrier for bounce bufferdrivers/net/ena/base/ena_eth_com.c+1 -10 replies
6/7net/ena: use c11 atomic for statisticsdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+29 -170 replies
7/7net/ena: remove duplicate memsetdrivers/net/ena/ena_ethdev.c+0 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchHonnappa Nagarahalli
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

To ensure the stores to the host memory are observed by NIC HW before a door bell ring to the NIC HW and the HW starts actions, for example, doing DMA, a barrier is required on weak memory ordering platforms, like aarch64.

However, unnecessarily too strong barriers like 'dsb' on aarch64 will dampen performance.

In a typical doorbell use case, as NIC and CPU are in the outer sharable domain, a lighter weight 'dmb osh' barrier is sufficient.

The patch set relaxes the barriers in similar places and include one more patch for statistics logging with relaxed ordering and the other patch removing duplicate memset.

Note this set is submitted for RFC as we don't have physical ENA NICs in the lab and the patch set was not verified nor benchmarked.

Gavin Hu (7):
net/ena: remove duplicate barrier
net/ena: relax the barrier for doorbell ring net/ena: relax the rmb for DMA
net/ena: relax barrier for completion queue update net/ena: relax the barrier for bounce buffer net/ena: use c11 atomic for statistics net/ena: remove duplicate memset

 drivers/net/ena/base/ena_eth_com.c   |  2 +-
 drivers/net/ena/base/ena_eth_com.h   |  6 ++--
 drivers/net/ena/base/ena_plat_dpdk.h |  2 +-
 drivers/net/ena/ena_ethdev.c         | 46 +++++++++++++++++-----------
 drivers/net/ena/ena_ethdev.h         |  8 ++---
 5 files changed, 38 insertions(+), 26 deletions(-)
Signature · 1 line
2.17.1