Skip to content

Add XHCI, EHCI and OHCI support for Broadcom STB SoS's

Al Cooper linux-devicetree linux-usb lkml 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest5 patches 13 repliesIn review
  2. v95 patches 2 repliesSuperseded
  3. v85 patches 8 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v75 patches2 repliesSuperseded
v64 patches8 repliesSuperseded
v54 patches2 repliesSuperseded
v44 patches3 repliesSuperseded
v34 patches9 repliesSuperseded
v24 patches10 repliesSuperseded
v14 patches10 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5usb: xhci: Change the XHCI link order in the Makefiledrivers/usb/host/Makefile+10 -613 replies
2/5dt-bindings: Add Broadcom STB USB supportDocumentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml Documentation/devicetree/bindings/usb/usb-xhci.txt+60 -00 replies
3/5usb: xhci: xhci-plat: Add support for Broadcom STB SoC'sdrivers/usb/host/xhci-plat.c+10 -00 replies
4/5usb: ehci: Add new EHCI driver for Broadcom STB SoC'sdrivers/usb/host/ehci-brcm.c+280 -00 replies
5/5usb: host: Add ability to build new Broadcom STB USB driversMAINTAINERS drivers/usb/host/Kconfig drivers/usb/host/Makefile+29 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliYoshihiro ShimodaRob HerringMathias NymanAndy ShevchenkoAlan Stern
1/5R-b T-b
2/5R-b R-b
3/5R-b A-b
4/5R-b R-b A-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v10 thread

Cover letter [PATCH v10 0/5] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's

v10 - Fix incorrect error return in ehci-brcmstb.c pointed out by
Alan Stern.

v9 - Fix minor typos in patch description for ehci driver.
- In ehci-brcm.c, use ehci_err() instead of dev_err().
- In ehci-brcm.c, handle zero returned from platform_get_irq() by returning -EINVAL for 0 or actual return value for < 0.

v8 - The previous v7 had the wrong version of ehci-brcm.c. This time
really, really add the changes Greg requested.

v7 - Cleanup ehci-brcm.c as requested by Greg Kroah-Hartman.
- Split out Makefile re-order change into a separate commit.

v6 - Remove "contains:" from compatible section of
brcm,bcm7445-ehci.yaml as requested by Rob Herring.

v5 - Use devm_platform_get_and_ioremap_resource() in ehci-brcm.c
as requested by Andy Shevchenko.
- Add pm_runtime_set_active() to ehci_resume() in ehci-brcm.c as requested by Alan Stern.

v4 - A few more fixes to the brcm,bcm7445-ehci.yaml dt-bindings
document requested by Rob Herring.
- Fixed ordering issue in MAINTAINERS as requested by Andy Shevchenko.

v3 - Addressed all of Andy Shevchenko's review comments for
ehci-brcm.c.
- Fixed the brcm,bcm7445-ehci.yaml dt-bindings document, dt_binding_check now passes.
- Added the XHCI functionality to xhci-plat.c instead of creating new brcmstb files, as suggested by Mathias Nyman.

v2 - Addressed Andy Shevchenko's review comments.
- Fixed dt_binding_check error pointed out by Rob Herring.
- Removed pr_info message in ehci_brcm_init as suggested by Greg Kroah-Hartman.

This adds support for the XHCI, EHCI and OHCI host controllers found in Broadcom STB SoC's. These drivers depend on getting access to the new Broadcom STB USB PHY driver through a device-tree phandle and will fail if the driver is not available.

Al Cooper (5):
usb: xhci: Change the XHCI link order in the Makefile
dt-bindings: Add Broadcom STB USB support
usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
usb: ehci: Add new EHCI driver for Broadcom STB SoC's
usb: host: Add ability to build new Broadcom STB USB drivers

 .../bindings/usb/brcm,bcm7445-ehci.yaml       |  59 ++++
 .../devicetree/bindings/usb/usb-xhci.txt      |   1 +
 MAINTAINERS                                   |   8 +
 drivers/usb/host/Kconfig                      |  20 ++
 drivers/usb/host/Makefile                     |  17 +-
 drivers/usb/host/ehci-brcm.c                  | 280 ++++++++++++++++++
 drivers/usb/host/xhci-plat.c                  |  10 +
 7 files changed, 389 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
 create mode 100644 drivers/usb/host/ehci-brcm.c
Signature · 1 line
2.17.1