Skip to content

drm/i915: Port sync for skl+

Ville Syrjala intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13drm/i915/mst: Use .compute_config_late() to compute master transcoderdrivers/gpu/drm/i915/display/intel_dp_mst.c+51 -472 replies
2/13drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belongsdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c+39 -663 replies
3/13drm/i915: Drop usless master_transcoder assignmentsdrivers/gpu/drm/i915/display/intel_display.c+0 -23 replies
4/13drm/i915: Move icl_get_trans_port_sync_config() into the DDI codedrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c+54 -591 reply
5/13drm/i915: Use REG_FIELD_PREP() & co. for TRANS_DDI_FUNC_CTL2drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/i915_reg.h+6 -101 reply
6/13drm/i915: Include port sync state in the state dumpdrivers/gpu/drm/i915/display/intel_display.c+5 -02 replies
7/13drm/i915: Store cpu_transcoder_mask in device infodrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +4 more+62 -322 replies
8/13drm/i915: Implement port sync for SKL+drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/i915_reg.h+59 -201 reply
9/13drm/i915: Eliminate port sync copy pastadrivers/gpu/drm/i915/display/intel_display.c+45 -831 reply
10/13drm/i915: Fix port sync code to work with >2 pipesdrivers/gpu/drm/i915/display/intel_display.c+49 -492 replies
11/13drm/i915: Do pipe updates after enables for everyonedrivers/gpu/drm/i915/display/intel_display.c+22 -221 reply
12/13drm/i915: Pass atomic state to encoder hooksdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_ddi.c +15 more+260 -1441 reply
13/13drm/i915: Move the port sync DP_TP_CTL stuff to the encoder hookdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c+53 -831 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchManasi NavareJosé Roberto de Souza
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 00/13] drm/i915: Port sync for skl+

From: Ville Syrjälä <[email protected]>

I got tired of waiting for the skl+ port sync to materialize so I went ahead and did it myself. Now we can maybe get this is into the hands of actual users.

In the process I also cleared out all the copy pasta that was added for port sync. LOC still went up though, but I think that's just due to plumbing the atomic state to the encoder hooks. Without that patch I think this results in a slight net reduction of code.

Lightly tested on a KBL by faking the tile info for a pair of extenal monitors (well, actually a single monitor plugged in via DP and HDMI->LSPCON->DP at the same time).

Oh, and I included a MST .compute_config_late() conversion as well since I figured I'd save CI a few cycles of testing that alone. Also I already had it in my WIP branch.

Ville Syrjälä (13):
drm/i915/mst: Use .compute_config_late() to compute master transcoder drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belongs drm/i915: Drop usless master_transcoder assignments drm/i915: Move icl_get_trans_port_sync_config() into the DDI code drm/i915: Use REG_FIELD_PREP() & co. for TRANS_DDI_FUNC_CTL2 drm/i915: Include port sync state in the state dump drm/i915: Store cpu_transcoder_mask in device info drm/i915: Implement port sync for SKL+
drm/i915: Eliminate port sync copy pasta
drm/i915: Fix port sync code to work with >2 pipes drm/i915: Do pipe updates after enables for everyone drm/i915: Pass atomic state to encoder hooks
drm/i915: Move the port sync DP_TP_CTL stuff to the encoder hook

 drivers/gpu/drm/i915/display/icl_dsi.c        |  15 +-
 drivers/gpu/drm/i915/display/intel_crt.c      |  33 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 289 +++++++++----
 drivers/gpu/drm/i915/display/intel_ddi.h      |   3 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 384 +++++-------------
 drivers/gpu/drm/i915/display/intel_display.h  |   8 +-
 .../drm/i915/display/intel_display_types.h    |  21 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  61 ++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   | 119 +++---
 drivers/gpu/drm/i915/display/intel_dvo.c      |   9 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |   3 +-
 drivers/gpu/drm/i915/display/intel_hdcp.h     |   4 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  59 ++-
 drivers/gpu/drm/i915/display/intel_lvds.c     |  22 +-
 drivers/gpu/drm/i915/display/intel_panel.c    |   3 +-
 drivers/gpu/drm/i915/display/intel_panel.h    |   3 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |  17 +-
 drivers/gpu/drm/i915/display/intel_tv.c       |   9 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  12 +-
 drivers/gpu/drm/i915/i915_drv.h               |   2 +-
 drivers/gpu/drm/i915/i915_pci.c               |  23 +-
 drivers/gpu/drm/i915/i915_reg.h               |  13 +-
 drivers/gpu/drm/i915/intel_device_info.c      |  41 +-
 drivers/gpu/drm/i915/intel_device_info.h      |   1 +
 24 files changed, 621 insertions(+), 533 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx