Skip to content

Drop some mis-uses of READA

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: do not use READA for running delayed refsfs/btrfs/extent-tree.c+0 -41 reply
2/2btrfs: do not READA in build_backref_treefs/btrfs/relocation.c+0 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Drop some mis-uses of READA

In debugging Zygo's huge commit delays I noticed we were burning a bunch of time doing READA in cases where we don't need to. The way READA works in btrfs is we'll load up adjacent nodes and leaves as we walk down. This is useful for operations where we're going to be reading sequentially across the tree.

But for delayed refs we're looking up one bytenr, and then another one which could be elsewhere in the tree. With large enough extent trees this results in a lot of unneeded latency.

The same applies to build_backref_tree, but that's even worse because we're looking up backrefs, which are essentially randomly spread out across the extent root. Thanks,

Josef