Skip to content

gitlab: Simplify the test script

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20200315151704.GQ12423@bill-the-cat

Versions newest first

  1. v1 Latest2 of 20 patches 0 repliesNew

2 of 20 patches are in this archive. The cover letter announces 20.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
12/20gitlab: Use -w flag for all builds+0 -01 reply
12/20gitlab: Use -w flag for all builds+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/20] gitlab: Simplify the test script
Quoted 33 lines · Simon Glass

Hi Tom,

Quoted 30 lines · Tom Rini
Quoted 27 lines · Simon Glass

Hi Tom,

Quoted 17 lines · Tom Rini
Quoted 9 lines · Simon Glass

At present there are several things in the gitlab script which work around limitations in buildman. With a few small feature additions these can be removed.

This series adds some new features to buildman and simplifies the script:
- Option to run a single build in a specified output directory
- Allow ignoring warnings
- Removes a restriction on the build output directory

Quoted 4 lines

It also
- moves test.py over to use buildman for the --build option
- makes one change to azure since the same approach should be possible there
- fixes a few minor problems noticed in main and sandbox docs

Quoted 4 lines

One general comment is that while it's clear from this series that you're focusing on test.py invocation most of the time, a lot of the commit messages aren't clear that you're changing the buildman_and_testpy_template stanza.

I'm not sure what you are looking for there. Do you want the commit message to mention which part of the gitlab file is being changed?

Quoted 7 lines
Quoted 3 lines

I mean a lot of places say something like "Change gitlab ..." but aren't changing any of the world builds, only test.py stuff, so I would prefer "Change gitlab when using test.py ..."

OK I will try. I've got the changes to all three environments in a single commit at present, so we don't end up with double the commis. Or would you prefer it split out?

Doing all CIs in step makes sense. So something like...:
Azure/GitLab/Travis: Change test.py and buildman ...

Quoted 3 lines

One more thing...I notice that gitlab and azure use 'set -ex' to avoid needing to check errors in the script. Is is possible for travis to do that do, or is there some restriction?

Not sure. When in doubt I always hack the heck out of .travis.yml to just be a testcase of what I want to figure out, push and see. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200315/991df2ba/attachment.sig>