zero pointer after bdrv_unref_child
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | block: bdrv_set_backing_bs: fix use-after-freeblock.c | +1 | 2 replies | |
| 2/2 | block/qcow2: zero data_file child after freeblock/ | +2 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | John Snow |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] zero pointer after bdrv_unref_child
Hi all!
I faced use-after-free of bs->backing pointer after bdrv_unref_child in bdrv_set_backing_hd.
Fix it, and do similar thing for s->data_file in qcow2.c.
I'm not sure that this is the full fix. Is it safe to keep bs->backing during bdrv_unref_child itself? Is it safe to keep bs->backing during all-child-unref loop in bdrv_close?
Vladimir Sementsov-Ogievskiy (2):
block: bdrv_set_backing_bs: fix use-after-free
block/qcow2: zero data_file child after free
block.c | 2 +- block/qcow2.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.21.0