Skip to content

Consider DBuf bandwidth when calculating CDCLK

Stanislav Lisovskiy intel-gfx 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest7 patches 15 repliesIn review
  2. v87 patches 5 repliesSuperseded
  3. v77 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v65 patches0 repliesSuperseded
v55 patches3 repliesSuperseded
v44 of 5 patches1 replySuperseded
v35 patches7 repliesSuperseded
v13 patches8 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915: Decouple cdclk calculation from modeset checksdrivers/gpu/drm/i915/display/intel_display.c+12 -100 replies
2/7drm/i915: Extract cdclk requirements checking to separate functiondrivers/gpu/drm/i915/display/intel_display.c+22 -80 replies
3/7drm/i915: Check plane configuration properlydrivers/gpu/drm/i915/display/intel_display.c+7 -10 replies
3/7drm/i915: Check plane configuration properlydrivers/gpu/drm/i915/display/intel_display.c+7 -10 replies
4/7drm/i915: Plane configuration affects CDCLK in Gen11+drivers/gpu/drm/i915/display/intel_display.c+1 -10 replies
4/7drm/i915: Plane configuration affects CDCLK in Gen11+drivers/gpu/drm/i915/display/intel_display.c+1 -10 replies
5/7drm/i915: Introduce for_each_dbuf_slice_in_mask macrodrivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/display/intel_display_power.h+8 -00 replies
6/7drm/i915: Adjust CDCLK accordingly to our DBuf bw needsdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_cdclk.c +5 more+217 -140 replies
6/7drm/i915: Adjust CDCLK accordingly to our DBuf bw needsdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_cdclk.c +5 more+218 -151 reply
6/7drm/i915: Adjust CDCLK accordingly to our DBuf bw needsdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_cdclk.c +5 more+220 -150 replies
7/7drm/i915: Remove unneeded hack now for CDCLKdrivers/gpu/drm/i915/display/intel_cdclk.c+0 -120 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchVille SyrjäläManasi Navare
1/7R-b
2/7R-b
3/7R-b R-b
3/7R-b R-b
4/7R-b R-b
4/7R-b R-b
5/7R-b
6/7R-b R-b
6/7R-b R-b
6/7R-b R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [Intel-gfx] [PATCH v9 0/7] Consider DBuf bandwidth when calculating CDCLK

We need to calculate cdclk after watermarks/ddb has been calculated as with recent hw CDCLK needs to be adjusted accordingly to DBuf requirements, which is not possible with current code organization.

Setting CDCLK according to DBuf BW requirements and not just rejecting if it doesn't satisfy BW requirements, will allow us to save power when it is possible and gain additional bandwidth when it's needed - i.e boosting both our power management and perfomance capabilities.

This patch is preparation for that, first we now extract modeset calculation from modeset checks, in order to call it after wm/ddb has been calculated.

Stanislav Lisovskiy (7):
drm/i915: Decouple cdclk calculation from modeset checks drm/i915: Extract cdclk requirements checking to separate function drm/i915: Check plane configuration properly
drm/i915: Plane configuration affects CDCLK in Gen11+ drm/i915: Introduce for_each_dbuf_slice_in_mask macro drm/i915: Adjust CDCLK accordingly to our DBuf bw needs drm/i915: Remove unneeded hack now for CDCLK

 drivers/gpu/drm/i915/display/intel_bw.c       | 118 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_bw.h       |  10 ++
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  40 +++---
 drivers/gpu/drm/i915/display/intel_cdclk.h    |   1 -
 drivers/gpu/drm/i915/display/intel_display.c  |  89 ++++++++++---
 drivers/gpu/drm/i915/display/intel_display.h  |   7 ++
 .../drm/i915/display/intel_display_power.h    |   1 +
 drivers/gpu/drm/i915/i915_drv.h               |   1 +
 drivers/gpu/drm/i915/intel_pm.c               |  31 ++++-
 drivers/gpu/drm/i915/intel_pm.h               |   3 +
 10 files changed, 261 insertions(+), 40 deletions(-)
Signature · 6 lines
2.24.1.485.gad05a3d8e5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx