Skip to content

ethtool: consolidate irq coalescing - last part

Jakub Kicinski netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: sfc: reject unsupported coalescing paramsdrivers/net/ethernet/sfc/ethtool.c drivers/net/ethernet/sfc/falcon/ethtool.c+6 -61 reply
2/9net: socionext: reject unsupported coalescing paramsdrivers/net/ethernet/socionext/netsec.c+2 -01 reply
3/9net: dwc-xlgmac: let core reject the unsupported coalescing parametersdrivers/net/ethernet/synopsys/dwc-xlgmac-ethtool.c+2 -150 replies
4/9net: tehuti: reject unsupported coalescing paramsdrivers/net/ethernet/tehuti/tehuti.c+2 -00 replies
5/9net: cpsw: reject unsupported coalescing paramsdrivers/net/ethernet/ti/cpsw.c drivers/net/ethernet/ti/cpsw_new.c+2 -01 reply
6/9net: davinci_emac: reject unsupported coalescing paramsdrivers/net/ethernet/ti/davinci_emac.c+1 -00 replies
7/9net: ll_temac: let core reject the unsupported coalescing parametersdrivers/net/ethernet/xilinx/ll_temac_main.c+2 -190 replies
8/9net: axienet: let core reject the unsupported coalescing parametersdrivers/net/ethernet/xilinx/xilinx_axienet_main.c+1 -210 replies
9/9net: ethtool: require drivers to set supported_coalesce_paramsinclude/linux/ethtool.h net/core/dev.c net/ethtool/common.c +1 more+17 -31 reply

Reviews trailers per patch

4 of 9 patches have a Reviewed-by or Acked-by.

PatchEdward CreeGrygorii StrashkoIlias ApalodimasMichal Kubecek
1/9A-b
2/9A-b
3/9
4/9
5/9R-b
6/9
7/9
8/9
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/9] ethtool: consolidate irq coalescing - last part

Hi!

Convert remaining drivers following the groundwork laid in a recent patch set [1] and continued in [2], [3], [4], [5]. The aim of the effort is to consolidate irq coalescing parameter validation in the core.

This set is the sixth and last installment. It converts the remaining 8 drivers in drivers/net/ethernet. The last patch makes declaring supported IRQ coalescing parameters a requirement.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/
[3] https://lore.kernel.org/netdev/[email protected]/
[4] https://lore.kernel.org/netdev/[email protected]/
[5] https://lore.kernel.org/netdev/[email protected]/

Jakub Kicinski (9):
net: sfc: reject unsupported coalescing params
net: socionext: reject unsupported coalescing params
net: dwc-xlgmac: let core reject the unsupported coalescing parameters
net: tehuti: reject unsupported coalescing params
net: cpsw: reject unsupported coalescing params
net: davinci_emac: reject unsupported coalescing params
net: ll_temac: let core reject the unsupported coalescing parameters
net: axienet: let core reject the unsupported coalescing parameters
net: ethtool: require drivers to set supported_coalesce_params

 drivers/net/ethernet/sfc/ethtool.c            |  6 ++---
 drivers/net/ethernet/sfc/falcon/ethtool.c     |  6 ++---
 drivers/net/ethernet/socionext/netsec.c       |  2 ++
 .../ethernet/synopsys/dwc-xlgmac-ethtool.c    | 17 ++------------
 drivers/net/ethernet/tehuti/tehuti.c          |  2 ++
 drivers/net/ethernet/ti/cpsw.c                |  1 +
 drivers/net/ethernet/ti/cpsw_new.c            |  1 +
 drivers/net/ethernet/ti/davinci_emac.c        |  1 +
 drivers/net/ethernet/xilinx/ll_temac_main.c   | 21 ++----------------
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 22 +------------------
 include/linux/ethtool.h                       |  2 ++
 net/core/dev.c                                |  4 ++++
 net/ethtool/common.c                          | 11 ++++++++++
 net/ethtool/ioctl.c                           |  3 ---
 14 files changed, 35 insertions(+), 64 deletions(-)
Signature · 1 line
2.24.1