Skip to content

iommu/vt-d: Add page request draining support

Lu Baolu linux-iommu lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 0 repliesNew
  2. v45 patches 15 repliesSuperseded
  3. v34 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches16 repliesSuperseded
v15 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Only set FPD bit in PASID entry when entry changed from present

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5iommu/vt-d: Multiple descriptors per qi_submit_sync()drivers/iommu/dmar.c drivers/iommu/intel-pasid.c drivers/iommu/intel-svm.c +2 more+52 -320 replies
2/5iommu/vt-d: debugfs: Add support to show inv queue internalsdrivers/iommu/intel-iommu-debugfs.c+62 -00 replies
3/5iommu/vt-d: Disable non-recoverable fault processing before unbinddrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.c drivers/iommu/intel-pasid.h +1 more+32 -110 replies
4/5iommu/vt-d: Add page request draining supportdrivers/iommu/intel-svm.c include/linux/intel-iommu.h+106 -50 replies
5/5iommu/vt-d: Remove redundant IOTLB flushdrivers/iommu/intel-svm.c+1 -50 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchKevin TianJacob Pan
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] iommu/vt-d: Add page request draining support

When a PASID is stopped or terminated, there can be pending PRQs (requests that haven't received responses) in the software and remapping hardware. The pending page requests must be drained so that the pasid could be reused. The chapter 7.10 in the VT-d specification specifies the software steps to drain pending page requests and responses.

This includes two parts:
- PATCH 1/5 ~ 2/5: refactor the qi_submit_sync() to support multiple descriptors per submission which will be used in the following patch.
- PATCH 3/5 ~ 5/5: add page request drain support after a pasid entry is torn down.

This series is based on Jacob's vSVA support hence the guest pasid could also be drained.

https://lkml.org/lkml/2020/4/21/1038

Best regards,
baolu

Change log:
v4->v5:
- Only set FPD bit in PASID entry when entry changed from present

    to non-present;

- Check pri_support in drain helper;
- Refine the wait/completion usage.

v3->v4:
- Remove prq drain in mm notifier;
- Set PASID FPD bit when pasid is cleared in mm notifier and clear it in unbound().

v2->v3:
- Address Kevin's review comments
- Squash the first 2 patches together;
- The prq thread is serialized, no need to consider reentrance;
- Ensure no new-coming prq before drain prq in queue;
- Handle page request overflow case.

v1->v2:
- Fix race between multiple prq handling threads.

Lu Baolu (5):
iommu/vt-d: Multiple descriptors per qi_submit_sync() iommu/vt-d: debugfs: Add support to show inv queue internals iommu/vt-d: Disable non-recoverable fault processing before unbind iommu/vt-d: Add page request draining support iommu/vt-d: Remove redundant IOTLB flush

 drivers/iommu/dmar.c                |  63 ++++++++------
 drivers/iommu/intel-iommu-debugfs.c |  62 ++++++++++++++
 drivers/iommu/intel-iommu.c         |   4 +-
 drivers/iommu/intel-pasid.c         |  30 +++++--
 drivers/iommu/intel-pasid.h         |   4 +-
 drivers/iommu/intel-svm.c           | 128 ++++++++++++++++++++++++----
 drivers/iommu/intel_irq_remapping.c |   2 +-
 include/linux/intel-iommu.h         |  13 ++-
 8 files changed, 253 insertions(+), 53 deletions(-)
Signature · 1 line
2.17.1