Skip to content

RFC pwm: sun4i: Properly turn pwm off and fix stuck output state

Pascal Roeleven linux-arm-kernel linux-pwm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pwm: sun4i: Remove redundant needs_delaydrivers/pwm/pwm-sun4i.c+2 -111 reply
2/4pwm: sun4i: Disable pwm before turning off clock gatedrivers/pwm/pwm-sun4i.c+2 -31 reply
3/4pwm: sun4i: Move delay to functiondrivers/pwm/pwm-sun4i.c+18 -141 reply
4/4pwm: sun4i: Delay after writing the perioddrivers/pwm/pwm-sun4i.c+5 -03 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchChen-Yu Tsai
1/4
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/4] pwm: sun4i: Properly turn pwm off and fix stuck output state

Hi all,

For the last few days I've been debugging a lot to get pwm working again since recent changes in 5.6-rc1 broke it for me.

Testing shows the pwm controller crashes (or the output gets stuck) when the period register is written when the channel is disabled while the clock gate is still on. Usually after multiple writes, but one write can also lead to unpredictable behaviour. Patch 3 and 4 fix this.

Patch 2 contains a fix which wouldn't completely turn off the pwm if the output is disabled. The clock gate needs to stay on for at least one more period to ensure the output is properly disabled. This issue has been around for a long time but has probably stayed unnoticed because if the duty_cycle is also changed to 0, you can't tell the difference.

Patch 1 removes some leftovers which aren't needed anymore.

Obviously these patches work for my device, but I'd like to hear your opinion if any of these changes make sense. After days, this one is a bit blurry for me.

Thanks to Uwe for some help with debugging.

Pascal.

Pascal Roeleven (4):
pwm: sun4i: Remove redundant needs_delay
pwm: sun4i: Disable pwm before turning off clock gate
pwm: sun4i: Move delay to function
pwm: sun4i: Delay after writing the period

 drivers/pwm/pwm-sun4i.c | 53 ++++++++++++++++++++---------------------
 1 file changed, 26 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1