Skip to content

batman-adv: Pending fixes

Sven Eckelmann stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest48 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/48batman-adv: Fix invalid read while copying bat_iv.bcast_ownnet/batman-adv/bat_iv_ogm.c+4 -20 replies
2/48batman-adv: Only put gw_node list reference when removednet/batman-adv/gateway_client.c+4 -30 replies
3/48batman-adv: Only put orig_node_vlan list reference when removednet/batman-adv/translation-table.c+4 -20 replies
4/48batman-adv: Avoid endless loop in bat-on-bat netdevice checknet/batman-adv/hard-interface.c+25 -00 replies
5/48batman-adv: Fix unexpected free of bcast_own on add_if errornet/batman-adv/bat_iv_ogm.c+1 -30 replies
6/48batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tqnet/batman-adv/bat_iv_ogm.c+3 -20 replies
7/48batman-adv: init neigh node last seen fieldnet/batman-adv/originator.c+1 -00 replies
8/48batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdownnet/batman-adv/hard-interface.c+1 -20 replies
9/48batman-adv: Drop reference to netdevice on last referencenet/batman-adv/hard-interface.c net/batman-adv/hard-interface.h+11 -80 replies
10/48batman-adv: Fix reference counting of vlan object for tt_local_entrynet/batman-adv/translation-table.c net/batman-adv/types.h+7 -390 replies
11/48batman-adv: Avoid duplicate neigh_node additionsnet/batman-adv/originator.c+4 -20 replies
12/48batman-adv: fix skb deref after freenet/batman-adv/routing.c+3 -10 replies
13/48batman-adv: Fix use-after-free/double-free of tt_req_nodenet/batman-adv/translation-table.c net/batman-adv/types.h+39 -60 replies
14/48batman-adv: Fix ICMP RR ethernet access after skb_linearizenet/batman-adv/routing.c+1 -00 replies
15/48batman-adv: Clean up untagged vlan when destroying via rtnl-linknet/batman-adv/soft-interface.c+9 -00 replies
16/48batman-adv: Avoid nullptr dereference in bla after vlan_insert_tagnet/batman-adv/bridge_loop_avoidance.c+4 -10 replies
17/48batman-adv: Avoid nullptr dereference in dat after vlan_insert_tagnet/batman-adv/distributed-arp-table.c+8 -20 replies
18/48batman-adv: Fix orig_node_vlan leak on orig_node_releasenet/batman-adv/originator.c+8 -00 replies
19/48batman-adv: lock crc access in bridge loop avoidancenet/batman-adv/bridge_loop_avoidance.c net/batman-adv/types.h+32 -50 replies
20/48batman-adv: Fix non-atomic bla_claim::backbone_gw accessnet/batman-adv/bridge_loop_avoidance.c net/batman-adv/types.h+90 -230 replies
21/48batman-adv: Fix reference leak in batadv_find_routernet/batman-adv/routing.c net/batman-adv/types.h+42 -140 replies
22/48batman-adv: Free last_bonding_candidate on release of orig_nodenet/batman-adv/originator.c+7 -00 replies
23/48batman-adv: Fix speedy join in gateway client modenet/batman-adv/send.c+2 -20 replies
24/48batman-adv: Add missing refcnt for last_candidatenet/batman-adv/routing.c+27 -10 replies
25/48batman-adv: Fix double free during fragment merge errornet/batman-adv/fragmentation.c net/batman-adv/routing.c+10 -20 replies
26/48batman-adv: Fix transmission of final, 16th fragmentnet/batman-adv/fragmentation.c+4 -40 replies
27/48batman-adv: Fix rx packet/bytes stats on local ARP replynet/batman-adv/distributed-arp-table.c+3 -20 replies
28/48batman-adv: fix TT sync flag inconsistenciesnet/batman-adv/translation-table.c net/batman-adv/types.h+50 -70 replies
29/48batman-adv: Fix lock for ogm cnt access in batadv_iv_ogm_calc_tqnet/batman-adv/bat_iv_ogm.c+2 -20 replies
30/48batman-adv: Fix internal interface indices typesnet/batman-adv/bat_iv_ogm.c net/batman-adv/hard-interface.c net/batman-adv/originator.c +2 more+24 -170 replies
31/48batman-adv: update data pointers after skb_cow()net/batman-adv/routing.c+4 -10 replies
32/48batman-adv: Fix skbuff rcsum on packet reroutenet/batman-adv/routing.c+10 -50 replies
33/48batman-adv: Avoid race in TT TVLV allocator helpernet/batman-adv/translation-table.c+4 -40 replies
34/48batman-adv: Fix TT sync flags for intermediate TT responsesnet/batman-adv/translation-table.c+29 -80 replies
35/48batman-adv: prevent TT request storms by not sending inconsistent TT TLVLsnet/batman-adv/translation-table.c+12 -30 replies
36/48batman-adv: Fix debugfs path for renamed hardifnet/batman-adv/debugfs.c net/batman-adv/debugfs.h net/batman-adv/hard-interface.c+29 -00 replies
37/48batman-adv: Fix debugfs path for renamed softifnet/batman-adv/debugfs.c net/batman-adv/debugfs.h net/batman-adv/hard-interface.c+53 -60 replies
38/48batman-adv: Avoid storing non-TT-sync flags on singular entries toonet/batman-adv/translation-table.c+2 -10 replies
39/48batman-adv: Prevent duplicated gateway_node entrynet/batman-adv/gateway_client.c+9 -20 replies
40/48batman-adv: Prevent duplicated nc_node entrynet/batman-adv/network-coding.c+15 -180 replies
41/48batman-adv: Prevent duplicated global TT entrynet/batman-adv/translation-table.c+4 -20 replies
42/48batman-adv: Prevent duplicated tvlv handlernet/batman-adv/main.c+6 -20 replies
43/48batman-adv: Reduce claim hash refcnt only for removed entrynet/batman-adv/bridge_loop_avoidance.c+13 -30 replies
44/48batman-adv: Reduce tt_local hash refcnt only for removed entrynet/batman-adv/translation-table.c+9 -50 replies
45/48batman-adv: Reduce tt_global hash refcnt only for removed entrynet/batman-adv/translation-table.c+15 -30 replies
46/48batman-adv: Only read OGM tvlv_len after buffer len checknet/batman-adv/bat_iv_ogm.c+12 -70 replies
47/48batman-adv: Avoid free/alloc race when handling OGM buffernet/batman-adv/bat_iv_ogm.c net/batman-adv/hard-interface.c net/batman-adv/types.h+55 -60 replies
48/48batman-adv: Don't schedule OGM for disabled interfacenet/batman-adv/bat_iv_ogm.c+4 -00 replies

Reviews trailers per patch

10 of 48 patches have a Reviewed-by or Acked-by.

PatchAntonio QuartulliSven EckelmannMartin WeineltAmadeus AlfaAlfons NameMarek Lindner
1/48
2/48
3/48
4/48
5/48
6/48
7/48
8/48
9/48
10/48A-b
11/48
12/48R-b
13/48T-b T-b
14/48
15/48A-b
16/48
17/48
18/48
19/48T-b
20/48
21/48
22/48
23/48A-b
24/48
25/48
26/48
27/48
28/48A-b
29/48
30/48
31/48
32/48
33/48A-b
34/48
35/48
36/48
37/48
38/48
39/48A-b
40/48A-b
41/48
42/48
43/48
44/48
45/48A-b
46/48A-b
47/48
48/48

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 4.4 00/48] batman-adv: Pending fixes

Hi,

we were asked by Greg KH to check the failed backport of some recent fix to linux 4.4.y and provide backports for it when required. I've found a lot more missing patches than I've expected in this process and queued them up here.

Kind regards,
Sven

Andrew Lunn (1):
batman-adv: Avoid endless loop in bat-on-bat netdevice check

Florian Westphal (1):
batman-adv: fix skb deref after free

Linus Lüssing (5):
batman-adv: Avoid duplicate neigh_node additions
batman-adv: Fix transmission of final, 16th fragment
batman-adv: fix TT sync flag inconsistencies
batman-adv: Fix TT sync flags for intermediate TT responses
batman-adv: Avoid storing non-TT-sync flags on singular entries too

Marek Lindner (2):
batman-adv: init neigh node last seen field
batman-adv: prevent TT request storms by not sending inconsistent TT
TLVLs

Matthias Schiffer (1):
batman-adv: update data pointers after skb_cow()

Simon Wunderlich (1):
batman-adv: lock crc access in bridge loop avoidance

Sven Eckelmann (37):
batman-adv: Fix invalid read while copying bat_iv.bcast_own
batman-adv: Only put gw_node list reference when removed
batman-adv: Only put orig_node_vlan list reference when removed
batman-adv: Fix unexpected free of bcast_own on add_if error
batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq
batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown
batman-adv: Drop reference to netdevice on last reference
batman-adv: Fix reference counting of vlan object for tt_local_entry
batman-adv: Fix use-after-free/double-free of tt_req_node
batman-adv: Fix ICMP RR ethernet access after skb_linearize
batman-adv: Clean up untagged vlan when destroying via rtnl-link
batman-adv: Avoid nullptr dereference in bla after vlan_insert_tag
batman-adv: Avoid nullptr dereference in dat after vlan_insert_tag
batman-adv: Fix orig_node_vlan leak on orig_node_release
batman-adv: Fix non-atomic bla_claim::backbone_gw access
batman-adv: Fix reference leak in batadv_find_router
batman-adv: Free last_bonding_candidate on release of orig_node
batman-adv: Fix speedy join in gateway client mode
batman-adv: Add missing refcnt for last_candidate
batman-adv: Fix double free during fragment merge error
batman-adv: Fix rx packet/bytes stats on local ARP reply
batman-adv: Fix lock for ogm cnt access in batadv_iv_ogm_calc_tq
batman-adv: Fix internal interface indices types
batman-adv: Fix skbuff rcsum on packet reroute
batman-adv: Avoid race in TT TVLV allocator helper
batman-adv: Fix debugfs path for renamed hardif
batman-adv: Fix debugfs path for renamed softif
batman-adv: Prevent duplicated gateway_node entry
batman-adv: Prevent duplicated nc_node entry
batman-adv: Prevent duplicated global TT entry
batman-adv: Prevent duplicated tvlv handler
batman-adv: Reduce claim hash refcnt only for removed entry
batman-adv: Reduce tt_local hash refcnt only for removed entry
batman-adv: Reduce tt_global hash refcnt only for removed entry
batman-adv: Only read OGM tvlv_len after buffer len check
batman-adv: Avoid free/alloc race when handling OGM buffer
batman-adv: Don't schedule OGM for disabled interface

 net/batman-adv/bat_iv_ogm.c            | 115 +++++++++---
 net/batman-adv/bridge_loop_avoidance.c | 152 ++++++++++++---
 net/batman-adv/debugfs.c               |  40 ++++
 net/batman-adv/debugfs.h               |  11 ++
 net/batman-adv/distributed-arp-table.c |  15 +-
 net/batman-adv/fragmentation.c         |  14 +-
 net/batman-adv/gateway_client.c        |  18 +-
 net/batman-adv/hard-interface.c        |  89 +++++++--
 net/batman-adv/hard-interface.h        |   6 +-
 net/batman-adv/main.c                  |   8 +-
 net/batman-adv/network-coding.c        |  33 ++--
 net/batman-adv/originator.c            |  26 ++-
 net/batman-adv/originator.h            |   4 +-
 net/batman-adv/routing.c               | 111 ++++++++---
 net/batman-adv/send.c                  |   4 +-
 net/batman-adv/soft-interface.c        |   9 +
 net/batman-adv/translation-table.c     | 249 +++++++++++++++++--------
 net/batman-adv/types.h                 |  23 ++-
 18 files changed, 707 insertions(+), 220 deletions(-)
Signature · 1 line
2.20.1