RFC test/kms: Use bare number of crtc index to
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest1 patch 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | test/kms: Use bare number of crtc index to get a pipelib/ lib/ tests/ | +121 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [igt-dev] [PATCH i-g-t 0/1] [RFC 0/1] test/kms: Use bare number of crtc index to
In non-continous pipe display,
1. if PIPE_B,C is disabled in kernel, PIPE_A & PIPE_D get registered with 0,1 indexes in display pipes[] array and kmstest_pipe_name() always prints PIPE_B for enum pipe 1 which is actually PIPE_D in kernel.
2. And in kernel the possible_crtc bit map is based on crtc index and for PIPE_D second least bit set in possible_crtc, macro for_each_pipe_with_valid_output() with enum pipe index always assumes PIPE_B for second least bit in possible_crtc but it is PIPE_D in kernel.
To avoid this using bare number of crtc index
to get a pipe from display->pipes[] array to support non-continuous pipe display.
This is a sample change to review on usage of bare number of
https://patchwork.freedesktop.org/series/74431/
crtc index for each pipe, based upon the review the patch series will be updated with this change.
Mohammed Khajapasha (1):
test/kms: Use bare number of crtc index to get a pipe
lib/igt_kms.c | 22 ++-- lib/igt_kms.h | 26 ++--- tests/kms_atomic_transition.c | 196 +++++++++++++++++----------------- 3 files changed, 121 insertions(+), 123 deletions(-)
Signature · 6 lines
2.24.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev