serial: 8250: Add rs485 emulation to 8250_dw
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 19 repliesIn review
- v2 RFC7 patches 15 repliesSuperseded
- v17 patches 16 repliesSuperseded
Changes in v3 from the cover letter
- wording fixes for dt-binding (Andy)
- maxItems 1 in dt-binding (Lukas)
- use devm_gpiod_get_optional (Andy)
- remove unneeded gpio checks (Andy)
- use GPIOD_OUT_HIGH for initial value (Lukas)
- split loop-reading into the existing timer infrastructure
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | serial: 8520_port: Fix function param documentationdrivers/ | +1 | 1 reply | |
| 2/5 | dt-bindings: serial: Add binding for rs485 receiver enable GPIODocumentation/ | +4 | 0 replies | |
| 3/5 | serial: 8250: Support separate rs485 rx-enable GPIOdrivers/ drivers/ include/ | +17 | 11 replies | |
| 4/5 | serial: 8250: Handle implementations not having TEMT interrupt using em485drivers/ drivers/ drivers/ +2 more | +51 | 1 reply | |
| 5/5 | serial: 8250_dw: add em485 supportdrivers/ | +3 | 5 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/5] serial: 8250: Add rs485 emulation to 8250_dw
This series tries to revive the work of Giulio Benetti from 2018 [0] which seemed to have stalled at that time.
The board I needed that on also had the additional caveat that it uses non-standard pins for DE/RE so needed gpio mctrl layer as well and even more special needed to control the RE pin manually not as part of it being connected to the DE signal as seems to be the standard.
Depends on Lukas Wunner's series adding the rs485 bus term gpio:
https://lore.kernel.org/r/[email protected]
changes in v3:
- wording fixes for dt-binding (Andy)
- maxItems 1 in dt-binding (Lukas)
- use devm_gpiod_get_optional (Andy)
- remove unneeded gpio checks (Andy)
- use GPIOD_OUT_HIGH for initial value (Lukas)
- split loop-reading into the existing timer infrastructure
Changes in v2:
- move to recent rs485 improvements in tty-next
- added a capability for TEMT interrupt presence
- external gpio for optional receiver-enable handling
- timeout polling via the generic readx_poll_timeout
Changes from the 2018 submission include:
- add timeout when waiting for fifos to clear using a new helper
- move on-boot enablement of the rs485 mode to after registering the port. This saves having to copy the em485 struct as done originally, which also ran into spinlock-debug warnings when testing and also makes it actually possible to use the mctrl gpio layer for non-standard gpios.
Giulio Benetti (2):
serial: 8250: Handle implementations not having TEMT interrupt using
em485
serial: 8250_dw: add em485 support
Heiko Stuebner (3):
serial: 8520_port: Fix function param documentation
dt-bindings: serial: Add binding for rs485 receiver enable GPIO
serial: 8250: Support separate rs485 rx-enable GPIO
.../devicetree/bindings/serial/rs485.yaml | 4 ++ drivers/tty/serial/8250/8250.h | 1 + drivers/tty/serial/8250/8250_bcm2835aux.c | 2 +- drivers/tty/serial/8250/8250_dw.c | 3 + drivers/tty/serial/8250/8250_of.c | 2 + drivers/tty/serial/8250/8250_omap.c | 2 +- drivers/tty/serial/8250/8250_port.c | 60 ++++++++++++++++--- drivers/tty/serial/serial_core.c | 10 ++++ include/linux/serial_core.h | 1 + 9 files changed, 76 insertions(+), 9 deletions(-)
Signature · 1 line
2.25.1