Skip to content

compress/qat: im buffer too small - split op

Adam Dybkowski dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 12 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

* refactor and simplify unit tests, removing the need of adding a new test suite separate for QAT-specific tests

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2compress/qat: im buffer too small - split opdoc/guides/compressdevs/qat_comp.rst doc/guides/cryptodevs/qat.rst doc/guides/rel_notes/release_20_05.rst +5 more+702 -740 replies
2/2test/compress: im buffer too small - add unit testsapp/test/test_compressdev.c+1118 -672 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFiona Trahe
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/2] compress/qat: im buffer too small - split op

This patch implements a special way of buffer handling when internal QAT IM buffer is too small for Huffman dynamic compression operation. Instead of falling back to fixed compression, the operation is now split into multiple smaller dynamic compression requests (possible to execute on QAT) and their results are then combined and copied into the output buffer. This is not possible if any checksum calculation was requested - in such case the code falls back to fixed compression as before.

v2:
* various post-review small fixes
v3:
* refactor and simplify unit tests, removing the need of adding a new test suite separate for QAT-specific tests

Adam Dybkowski (2):
compress/qat: im buffer too small - split op test/compress: im buffer too small - add unit tests

 app/test/test_compressdev.c            | 1185 ++++++++++++++++++++++--
 doc/guides/compressdevs/qat_comp.rst   |    3 -
 doc/guides/cryptodevs/qat.rst          |    7 +-
 doc/guides/rel_notes/release_20_05.rst |   10 +
 drivers/common/qat/qat_qp.c            |  223 ++++-
 drivers/common/qat/qat_qp.h            |    3 +
 drivers/compress/qat/qat_comp.c        |  474 +++++++++-
 drivers/compress/qat/qat_comp.h        |   29 +-
 drivers/compress/qat/qat_comp_pmd.c    |   27 +-
 9 files changed, 1820 insertions(+), 141 deletions(-)
Signature · 1 line
2.17.1