Skip to content

igc: Refactor MAC address filtering code

Andre Guedes intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12igc: Remove duplicate code in MAC filtering logicdrivers/net/ethernet/intel/igc/igc_main.c+13 -991 reply
2/12igc: Check unsupported flag in igc_add_mac_filter()drivers/net/ethernet/intel/igc/igc_main.c+2 -02 replies
3/12igc: Change igc_add_mac_filter() returning valuedrivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+2 -71 reply
4/12igc: Fix igc_uc_unsync()drivers/net/ethernet/intel/igc/igc_main.c+1 -31 reply
5/12igc: Refactor igc_rar_set_index()drivers/net/ethernet/intel/igc/igc_main.c+43 -325 replies
6/12igc: Improve address check in igc_del_mac_filter()drivers/net/ethernet/intel/igc/igc_main.c+1 -11 reply
7/12igc: Remove 'queue' check in igc_del_mac_filter()drivers/net/ethernet/intel/igc/igc_main.c+12 -154 replies
8/12igc: Remove IGC_MAC_STATE_QUEUE_STEERINGdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_main.c+21 -163 replies
9/12igc: Remove igc_*_mac_steering_filter() wrappersdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+16 -321 reply
10/12igc: Refactor igc_mac_entry_can_be_used()drivers/net/ethernet/intel/igc/igc_main.c+47 -331 reply
11/12igc: Refactor igc_del_mac_filter()drivers/net/ethernet/intel/igc/igc_main.c+19 -261 reply
12/12igc: Add debug messages to MAC filter codedrivers/net/ethernet/intel/igc/igc_main.c+22 -21 reply

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by.

PatchAaron Brown
1/12T-b
2/12T-b
3/12T-b
4/12T-b
5/12T-b T-b
6/12T-b
7/12T-b
8/12T-b T-b
9/12T-b
10/12T-b
11/12T-b
12/12T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH 00/12] igc: Refactor MAC address filtering code

Hi all,

The MAC address filtering support from IGC driver has some duplicate code and convoluted logic, making it harder to read, debug, and maintain.

As a follow-up to the bug fixes already applied to dev-queue, this patchset refactors the MAC address filtering code to address those issues. It also takes the opportunity to improve documentation from some key functions and clean up comments that are not applicable to IGC, and fix minor issues along the way.

In summary, the new MAC address filtering code is organized as follows:

* Filters are added and deleted only via igc_add_mac_filter() and igc_del_mac_filter() APIs. These APIs manage the adapter->mac_table. They are defined in igc_main.c and used in both igc_main.c and igc_ethtool.c.

* Filter configuration in hardware is handled by igc_set_mac_filter_ hw() and igc_clear_mac_filter_hw() local helpers in igc_main.c.

* IGC_MAC_STATE_QUEUE_STEERING flag as well as igc_*_mac_steering_ filter() are gone.

Best regards,

Andre

Andre Guedes (12):
igc: Remove duplicate code in MAC filtering logic
igc: Check unsupported flag in igc_add_mac_filter()
igc: Change igc_add_mac_filter() returning value
igc: Fix igc_uc_unsync()
igc: Refactor igc_rar_set_index()
igc: Improve address check in igc_del_mac_filter()
igc: Remove 'queue' check in igc_del_mac_filter()
igc: Remove IGC_MAC_STATE_QUEUE_STEERING
igc: Remove igc_*_mac_steering_filter() wrappers
igc: Refactor igc_mac_entry_can_be_used()
igc: Refactor igc_del_mac_filter()
igc: Add debug messages to MAC filter code

 drivers/net/ethernet/intel/igc/igc.h         |  11 +-
 drivers/net/ethernet/intel/igc/igc_ethtool.c |  22 +-
 drivers/net/ethernet/intel/igc/igc_main.c    | 372 ++++++++-----------
 3 files changed, 169 insertions(+), 236 deletions(-)
Signature · 1 line
2.25.0