microvm: add acpi support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest21 patches 1 replyIn review
- v721 patches 2 repliesSuperseded
- v620 patches 21 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 20 patches | 12 replies | Superseded | |
| v4 | 21 patches | 4 replies | Superseded | |
| v3 | 22 patches | 34 replies | Superseded | |
| v2 | 13 patches | 29 replies | Superseded | |
| v1 | 13 patches | 34 replies | Superseded |
Changes in v8 from the cover letter
* rebase to latest master, adapt to typedef changes.
* pick up some review tags.
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | microvm: name qboot binary qboot.romhw/ pc-bios/ pc-bios/ +1 more | +6 | 0 replies | |
| 2/21 | seabios: add microvm config, update build rulesroms/ roms/ | +30 | 0 replies | |
| 3/21 | seabios: add bios-microvm.bin binarypc-bios/ pc-bios/ | +1 | 0 replies | |
| 4/21 | acpi: ged: add control regshw/ include/ | +56 | 0 replies | |
| 5/21 | acpi: ged: add x86 device variant.hw/ hw/ include/ | +41 | 0 replies | |
| 6/21 | acpi: move acpi_dsdt_add_power_button() to gedhw/ hw/ include/ | +9 | 0 replies | |
| 7/21 | microvm: make virtio irq base runtime configurablehw/ include/ | +8 | 0 replies | |
| 8/21 | microvm/acpi: add minimal acpi supporthw/ hw/ hw/ +3 more | +246 | 0 replies | |
| 9/21 | microvm/acpi: add acpi_dsdt_add_virtio() for x86hw/ | +52 | 0 replies | |
| 10/21 | microvm/acpi: use GSI 16-23 for virtiohw/ | +1 | 0 replies | |
| 11/21 | microvm/acpi: use seabios with acpi=onhw/ | +4 | 0 replies | |
| 12/21 | microvm/acpi: disable virtio-mmio cmdline hackhw/ | +2 | 0 replies | |
| 13/21 | x86: constify x86_machine_is_*_enabledhw/ include/ | +4 | 0 replies | |
| 14/21 | x86: move acpi_dev from pc/microvmhw/ hw/ hw/ +6 more | +32 | 0 replies | |
| 15/21 | x86: move cpu hotplug from pc to x86hw/ hw/ include/ | +286 | 1 reply | |
| 16/21 | microvm: wire up hotplughw/ | +42 | 0 replies | |
| 17/21 | tests/acpi: allow microvm test data updates.tests/ tests/ tests/ +1 more | +3 | 0 replies | |
| 18/21 | tests/acpi: allow override blkdevtests/ | +4 | 0 replies | |
| 19/21 | tests/acpi: add microvm testtests/ | +15 | 0 replies | |
| 20/21 | tests/acpi: update expected data files for microvmtests/ tests/ tests/ +1 more | +0 | 0 replies | |
| 21/21 | microvm: enable ramfbhw/ | +3 | 0 replies |
Reviews trailers per patch
18 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Sergio Lopez | Igor Mammedov | Philippe Mathieu-Daudé |
|---|---|---|---|
| 1/21 | R-b | R-b | |
| 2/21 | R-b | ||
| 3/21 | R-b | ||
| 4/21 | R-b | ||
| 5/21 | R-b | ||
| 6/21 | R-b | R-b | |
| 7/21 | R-b | R-b | |
| 8/21 | R-b | ||
| 9/21 | R-b | R-b | |
| 10/21 | R-b | R-b | |
| 11/21 | R-b | R-b | |
| 12/21 | R-b | R-b | |
| 13/21 | R-b | R-b | R-b |
| 14/21 | R-b | R-b | |
| 15/21 | R-b | R-b | |
| 16/21 | R-b | R-b | |
| 17/21 | |||
| 18/21 | R-b | R-b | |
| 19/21 | R-b | ||
| 20/21 | |||
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v8 00/21] microvm: add acpi support
I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support.
These are the advantages you are going to loose then:
(1) virtio-mmio device discovery without command line hacks (tweaking the command line is a problem when not using direct kernel boot).
(2) Better IO-APIC support, we can use IRQ lines 16-23.
(3) ACPI power button (aka powerdown request) works.
(4) machine poweroff (aka S5 state) works.
Together with seabios patches for virtio-mmio support this allows to boot standard fedora images (cloud, coreos, workstation live) with the microvm machine type.
git branch for testing (including updated seabios):
https://git.kraxel.org/cgit/qemu/log/?h=sirius/microvm
changes in v2:
* some acpi cleanups are an separate patch series now.
* switched to hw reduced acpi & generic event device.
* misc fixes here and there.
changes in v3:
* depeds on "[PATCH v6 00/16] acpi: i386 tweaks" series.
* renamed qboot to qboot.bin
* updated seabios to master branch snapshot.
- this version boots fine with rtc=off
* generic event device tweaks (Igor's comments).
* make SMP work.
* add RfC patches to turn off acpi by default for microvm.
* misc fixes here and there.
changes in v4:
* rebase to latest master
- this also depends on the pending seabios update
* drop some patches which got cherry-picked.
* wire up cpu hotplug (also does coldplug cpu init).
* add microvm acpi test case.
* dropped RfC patches to turn off acpi by default for microvm.
* misc fixes here and there.
changes in v5:
* rebase to latest master (seabios dependency is merged meanwhile)
* fix DSDT version (mst).
* add comments referencing the ACPI spec for easier review (mst).
changes in v6:
* rebase to latest master, adapt to meson build system.
* pick up some review tags.
* misc fixes here and there.
changes in v7:
* rebase to latest master, adapt to x86 cpu hotplug changes.
* meson tweaks for firmware binaries.
* pick up some review tags.
changes in v8:
* rebase to latest master, adapt to typedef changes.
* pick up some review tags.
take care,
Gerd
Gerd Hoffmann (21):
microvm: name qboot binary qboot.rom
seabios: add microvm config, update build rules
seabios: add bios-microvm.bin binary
acpi: ged: add control regs
acpi: ged: add x86 device variant.
acpi: move acpi_dsdt_add_power_button() to ged
microvm: make virtio irq base runtime configurable microvm/acpi: add minimal acpi support microvm/acpi: add acpi_dsdt_add_virtio() for x86 microvm/acpi: use GSI 16-23 for virtio microvm/acpi: use seabios with acpi=on microvm/acpi: disable virtio-mmio cmdline hack
x86: constify x86_machine_is_*_enabled
x86: move acpi_dev from pc/microvm
x86: move cpu hotplug from pc to x86
microvm: wire up hotplug
tests/acpi: allow microvm test data updates. tests/acpi: allow override blkdev tests/acpi: add microvm test
tests/acpi: update expected data files for microvm
microvm: enable ramfb
hw/i386/acpi-microvm.h | 8 + include/hw/acpi/generic_event_device.h | 17 ++ include/hw/i386/microvm.h | 10 +- include/hw/i386/pc.h | 1 - include/hw/i386/x86.h | 15 +- hw/acpi/generic_event_device.c | 52 +++++ hw/arm/virt-acpi-build.c | 8 - hw/i386/acpi-build.c | 2 +- hw/i386/acpi-microvm.c | 240 ++++++++++++++++++++ hw/i386/generic_event_device_x86.c | 36 +++ hw/i386/microvm.c | 108 ++++++++- hw/i386/pc.c | 297 ++----------------------- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/i386/x86.c | 275 ++++++++++++++++++++++- tests/qtest/bios-tables-test.c | 21 +- hw/i386/Kconfig | 1 + hw/i386/meson.build | 3 +- pc-bios/bios-microvm.bin | Bin 65536 -> 131072 bytes pc-bios/meson.build | 1 + pc-bios/qboot.rom | Bin 0 -> 65536 bytes roms/Makefile | 11 +- roms/config.seabios-microvm | 26 +++ tests/data/acpi/microvm/APIC | Bin 0 -> 70 bytes tests/data/acpi/microvm/DSDT | Bin 0 -> 365 bytes tests/data/acpi/microvm/FACP | Bin 0 -> 268 bytes 26 files changed, 823 insertions(+), 313 deletions(-) create mode 100644 hw/i386/acpi-microvm.h create mode 100644 hw/i386/acpi-microvm.c create mode 100644 hw/i386/generic_event_device_x86.c create mode 100644 pc-bios/qboot.rom create mode 100644 roms/config.seabios-microvm create mode 100644 tests/data/acpi/microvm/APIC create mode 100644 tests/data/acpi/microvm/DSDT create mode 100644 tests/data/acpi/microvm/FACP
Signature · 1 line
2.27.0