Skip to content

microvm: add acpi support

Gerd Hoffmann qemu-arm qemu-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest21 patches 1 replyIn review
  2. v721 patches 2 repliesSuperseded
  3. v620 patches 21 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v520 patches12 repliesSuperseded
v421 patches4 repliesSuperseded
v322 patches34 repliesSuperseded
v213 patches29 repliesSuperseded
v113 patches34 repliesSuperseded

Changes in v8 from the cover letter

* rebase to latest master, adapt to typedef changes.
* pick up some review tags.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21microvm: name qboot binary qboot.romhw/i386/microvm.c pc-bios/meson.build pc-bios/qboot.rom +1 more+6 -60 replies
2/21seabios: add microvm config, update build rulesroms/Makefile roms/config.seabios-microvm+30 -10 replies
3/21seabios: add bios-microvm.bin binarypc-bios/bios-microvm.bin pc-bios/meson.build+1 -00 replies
4/21acpi: ged: add control regshw/acpi/generic_event_device.c include/hw/acpi/generic_event_device.h+56 -00 replies
5/21acpi: ged: add x86 device variant.hw/i386/generic_event_device_x86.c hw/i386/meson.build include/hw/acpi/generic_event_device.h+41 -00 replies
6/21acpi: move acpi_dsdt_add_power_button() to gedhw/acpi/generic_event_device.c hw/arm/virt-acpi-build.c include/hw/acpi/generic_event_device.h+9 -80 replies
7/21microvm: make virtio irq base runtime configurablehw/i386/microvm.c include/hw/i386/microvm.h+8 -50 replies
8/21microvm/acpi: add minimal acpi supporthw/i386/Kconfig hw/i386/acpi-microvm.c hw/i386/acpi-microvm.h +3 more+246 -10 replies
9/21microvm/acpi: add acpi_dsdt_add_virtio() for x86hw/i386/acpi-microvm.c+52 -00 replies
10/21microvm/acpi: use GSI 16-23 for virtiohw/i386/microvm.c+1 -10 replies
11/21microvm/acpi: use seabios with acpi=onhw/i386/microvm.c+4 -10 replies
12/21microvm/acpi: disable virtio-mmio cmdline hackhw/i386/microvm.c+2 -10 replies
13/21x86: constify x86_machine_is_*_enabledhw/i386/x86.c include/hw/i386/x86.h+4 -40 replies
14/21x86: move acpi_dev from pc/microvmhw/i386/acpi-build.c hw/i386/acpi-microvm.c hw/i386/microvm.c +6 more+32 -260 replies
15/21x86: move cpu hotplug from pc to x86hw/i386/pc.c hw/i386/x86.c include/hw/i386/x86.h+286 -2761 reply
16/21microvm: wire up hotplughw/i386/microvm.c+42 -00 replies
17/21tests/acpi: allow microvm test data updates.tests/data/acpi/microvm/APIC tests/data/acpi/microvm/DSDT tests/data/acpi/microvm/FACP +1 more+3 -00 replies
18/21tests/acpi: allow override blkdevtests/qtest/bios-tables-test.c+4 -20 replies
19/21tests/acpi: add microvm testtests/qtest/bios-tables-test.c+15 -00 replies
20/21tests/acpi: update expected data files for microvmtests/data/acpi/microvm/APIC tests/data/acpi/microvm/DSDT tests/data/acpi/microvm/FACP +1 more+0 -30 replies
21/21microvm: enable ramfbhw/i386/microvm.c+3 -00 replies

Reviews trailers per patch

18 of 21 patches have a Reviewed-by or Acked-by.

PatchSergio LopezIgor MammedovPhilippe Mathieu-Daudé
1/21R-b R-b
2/21R-b
3/21R-b
4/21R-b
5/21R-b
6/21R-b R-b
7/21R-b R-b
8/21R-b
9/21R-b R-b
10/21R-b R-b
11/21R-b R-b
12/21R-b R-b
13/21R-b R-b R-b
14/21R-b R-b
15/21R-b R-b
16/21R-b R-b
17/21
18/21R-b R-b
19/21R-b
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 00/21] microvm: add acpi support

I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support.

These are the advantages you are going to loose then:

(1) virtio-mmio device discovery without command line hacks (tweaking the command line is a problem when not using direct kernel boot).
(2) Better IO-APIC support, we can use IRQ lines 16-23.
(3) ACPI power button (aka powerdown request) works.
(4) machine poweroff (aka S5 state) works.

Together with seabios patches for virtio-mmio support this allows to boot standard fedora images (cloud, coreos, workstation live) with the microvm machine type.

git branch for testing (including updated seabios):
https://git.kraxel.org/cgit/qemu/log/?h=sirius/microvm

changes in v2:
* some acpi cleanups are an separate patch series now.
* switched to hw reduced acpi & generic event device.
* misc fixes here and there.

changes in v3:
* depeds on "[PATCH v6 00/16] acpi: i386 tweaks" series.
* renamed qboot to qboot.bin
* updated seabios to master branch snapshot.
- this version boots fine with rtc=off
* generic event device tweaks (Igor's comments).
* make SMP work.
* add RfC patches to turn off acpi by default for microvm.
* misc fixes here and there.

changes in v4:
* rebase to latest master
- this also depends on the pending seabios update
* drop some patches which got cherry-picked.
* wire up cpu hotplug (also does coldplug cpu init).
* add microvm acpi test case.
* dropped RfC patches to turn off acpi by default for microvm.
* misc fixes here and there.

changes in v5:
* rebase to latest master (seabios dependency is merged meanwhile)
* fix DSDT version (mst).
* add comments referencing the ACPI spec for easier review (mst).

changes in v6:
* rebase to latest master, adapt to meson build system.
* pick up some review tags.
* misc fixes here and there.

changes in v7:
* rebase to latest master, adapt to x86 cpu hotplug changes.
* meson tweaks for firmware binaries.
* pick up some review tags.

changes in v8:
* rebase to latest master, adapt to typedef changes.
* pick up some review tags.

take care,
Gerd

Gerd Hoffmann (21):
microvm: name qboot binary qboot.rom
seabios: add microvm config, update build rules
seabios: add bios-microvm.bin binary
acpi: ged: add control regs
acpi: ged: add x86 device variant.
acpi: move acpi_dsdt_add_power_button() to ged
microvm: make virtio irq base runtime configurable microvm/acpi: add minimal acpi support microvm/acpi: add acpi_dsdt_add_virtio() for x86 microvm/acpi: use GSI 16-23 for virtio microvm/acpi: use seabios with acpi=on microvm/acpi: disable virtio-mmio cmdline hack
x86: constify x86_machine_is_*_enabled
x86: move acpi_dev from pc/microvm
x86: move cpu hotplug from pc to x86
microvm: wire up hotplug
tests/acpi: allow microvm test data updates. tests/acpi: allow override blkdev tests/acpi: add microvm test
tests/acpi: update expected data files for microvm
microvm: enable ramfb

 hw/i386/acpi-microvm.h                 |   8 +
 include/hw/acpi/generic_event_device.h |  17 ++
 include/hw/i386/microvm.h              |  10 +-
 include/hw/i386/pc.h                   |   1 -
 include/hw/i386/x86.h                  |  15 +-
 hw/acpi/generic_event_device.c         |  52 +++++
 hw/arm/virt-acpi-build.c               |   8 -
 hw/i386/acpi-build.c                   |   2 +-
 hw/i386/acpi-microvm.c                 | 240 ++++++++++++++++++++
 hw/i386/generic_event_device_x86.c     |  36 +++
 hw/i386/microvm.c                      | 108 ++++++++-
 hw/i386/pc.c                           | 297 ++-----------------------
 hw/i386/pc_piix.c                      |   2 +-
 hw/i386/pc_q35.c                       |   2 +-
 hw/i386/x86.c                          | 275 ++++++++++++++++++++++-
 tests/qtest/bios-tables-test.c         |  21 +-
 hw/i386/Kconfig                        |   1 +
 hw/i386/meson.build                    |   3 +-
 pc-bios/bios-microvm.bin               | Bin 65536 -> 131072 bytes
 pc-bios/meson.build                    |   1 +
 pc-bios/qboot.rom                      | Bin 0 -> 65536 bytes
 roms/Makefile                          |  11 +-
 roms/config.seabios-microvm            |  26 +++
 tests/data/acpi/microvm/APIC           | Bin 0 -> 70 bytes
 tests/data/acpi/microvm/DSDT           | Bin 0 -> 365 bytes
 tests/data/acpi/microvm/FACP           | Bin 0 -> 268 bytes
 26 files changed, 823 insertions(+), 313 deletions(-)
 create mode 100644 hw/i386/acpi-microvm.h
 create mode 100644 hw/i386/acpi-microvm.c
 create mode 100644 hw/i386/generic_event_device_x86.c
 create mode 100644 pc-bios/qboot.rom
 create mode 100644 roms/config.seabios-microvm
 create mode 100644 tests/data/acpi/microvm/APIC
 create mode 100644 tests/data/acpi/microvm/DSDT
 create mode 100644 tests/data/acpi/microvm/FACP
Signature · 1 line
2.27.0