Skip to content

Replaced locks with lock guard macros

[email protected] qemu-devel 5 versions – Applied

Status from this message: Thanks, applied to my block-next tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 7 repliesApplied
  2. v42 patches 12 repliesSuperseded
  3. v32 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v20 of 2 patches0 repliesSuperseded
v11 patch4 repliesSuperseded

Changes in v5 from the cover letter

- added G_GNUC_UNUSED to lock guard macro to supress unused var warning

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2lockable: fix __COUNTER__ macro to be referenced properlyinclude/qemu/lockable.h include/qemu/rcu.h+5 -40 replies
2/2lockable: replaced locks with lock guard macros where appropriateblock/iscsi.c block/nfs.c cpus-common.c +12 more+83 -1065 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJuan Quintela
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] Replaced locks with lock guard macros

From: Daniel Brodsky <[email protected]>

This patch set adds:
- a fix for lock guard macros so they can be used multiple times in the same function
- replacement of locks with lock guards where appropriate

v4 -> v5:
- added G_GNUC_UNUSED to lock guard macro to supress unused var warning

v3 -> v4:
- removed unneeded unlocks from areas where lock guards are now used
- dropped change to lock guard in iscsi.c as it changed old functionality

v2 -> v3:
- added __COUNTER__ fix for additional lock guard macro
- added missing include header in platform.c

v1 -> v2:
- fixed whitespace churn
- added cover letter so patch set referenced correctly

Daniel Brodsky (2):
lockable: fix __COUNTER__ macro to be referenced properly
lockable: replaced locks with lock guard macros where appropriate

 block/iscsi.c           |  7 ++----
 block/nfs.c             | 51 +++++++++++++++++++----------------------
 cpus-common.c           | 14 ++++-------
 hw/display/qxl.c        | 43 ++++++++++++++++------------------
 hw/vfio/platform.c      |  5 ++--
 include/qemu/lockable.h |  7 +++---
 include/qemu/rcu.h      |  2 +-
 migration/migration.c   |  3 +--
 migration/multifd.c     |  8 +++----
 migration/ram.c         |  3 +--
 monitor/misc.c          |  4 +---
 ui/spice-display.c      | 14 +++++------
 util/log.c              |  4 ++--
 util/qemu-timer.c       | 17 +++++++-------
 util/rcu.c              |  8 +++----
 util/thread-pool.c      |  3 +--
 util/vfio-helpers.c     |  5 ++--
 17 files changed, 88 insertions(+), 110 deletions(-)
Signature · 1 line
2.26.0