Fix SVM hang at startup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | KVM: PPC: Book3S HV: check caller of H_SVM_* Hcallsarch/ | +21 | 6 replies | |
| 2/2 | KVM: PPC: Book3S HV: H_SVM_INIT_START must call UV_RETURNarch/ | +2 | 5 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Ram Pai | Fabiano Rosas |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] Fix SVM hang at startup
This series is fixing a SVM hang occurring when starting a SVM requiring more secure memory than available. The hang happens in the SVM when calling UV_ESM.
The following is happening:
1. SVM calls UV_ESM
2. Ultravisor (UV) calls H_SVM_INIT_START
3. Hypervisor (HV) calls UV_REGISTER_MEM_SLOT
4. UV returns error because there is not enough free secure memory
5. HV enter the error path in kvmppc_h_svm_init_start()
6. In the return path, since kvm->arch.secure_guest is not yet set hrfid is called
7. As the HV doesn't know the SVM calling context hrfid is jumping to unknown address in the SVM leading to various expections.
This series fixes the setting of kvm->arch.secure_guest in kvmppc_h_svm_init_start() to ensure that UV_RETURN is called on the return path to get back to the UV.
In addition to ensure that a malicious VM will not call UV reserved Hcall, a check of the Secure bit in the calling MSR is addded to reject such a call.
It is assumed that the UV will filtered out such Hcalls made by a malicious SVM.
Laurent Dufour (2):
KVM: PPC: Book3S HV: check caller of H_SVM_* Hcalls
KVM: PPC: Book3S HV: H_SVM_INIT_START must call UV_RETURN
arch/powerpc/kvm/book3s_hv.c | 32 ++++++++++++++++++++---------- arch/powerpc/kvm/book3s_hv_uvmem.c | 3 ++- 2 files changed, 23 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.2