Skip to content

ASoC: topology: Propagate error appropriately

Amadeusz Sławiński alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 17 repliesIn review
  2. v11 patch 2 repliesSuperseded

Changes in v2 from the cover letter

Remove unneeded freeing, which is performed in another place by dobj handlers.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ASoC: topology: Add missing memory checkssound/soc/soc-topology.c+49 -131 reply
2/6ASoC: topology: Check return value of soc_tplg_create_tlvsound/soc/soc-topology.c+14 -21 reply
3/6ASoC: topology: Check return value of soc_tplg_*_createsound/soc/soc-topology.c+12 -66 replies
4/6ASoC: topology: Check soc_tplg_add_route return valuesound/soc/soc-topology.c+3 -11 reply
5/6ASoC: topology: Check return value of pcm_new_versound/soc/soc-topology.c+3 -11 reply
6/6ASoC: topology: Check return value of soc_tplg_dai_configsound/soc/soc-topology.c+7 -21 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRanjani SridharanPierre-Louis Bossart
SeriesR-b R-b
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] ASoC: topology: Propagate error appropriately

v1:
Check if kstrdup succeeded.

v2:
Remove unneeded freeing, which is performed in another place by dobj handlers.

Additionally for functions which have return status which was ignored, perform success checks and handle failures in appropriate way.

Amadeusz Sławiński (6):
ASoC: topology: Add missing memory checks
ASoC: topology: Check return value of soc_tplg_create_tlv
ASoC: topology: Check return value of soc_tplg_*_create
ASoC: topology: Check soc_tplg_add_route return value
ASoC: topology: Check return value of pcm_new_ver
ASoC: topology: Check return value of soc_tplg_dai_config

 sound/soc/soc-topology.c | 113 ++++++++++++++++++++++++++++++---------
 1 file changed, 88 insertions(+), 25 deletions(-)
Signature · 1 line
2.17.1