misc: Trivial static code analyzer fixes
Status from this message: Applied to my trivial-patches branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 4 repliesApplied
- v211 patches 16 repliesSuperseded
- v111 patches 16 repliesSuperseded
Changes in v3 from the cover letter
- Based on lvivier/trivial-patches-for-5.1
- Removed dup patches from Kuhn Chenqun Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | block: Avoid dead assignmentblock.c | +1 | 1 reply | |
| 2/9 | blockdev: Remove dead assignmentblockdev.c | +1 | 1 reply | |
| 3/9 | hw/i2c/pm_smbus: Remove dead assignmenthw/ | +0 | 0 replies | |
| 4/9 | hw/input/adb-kbd: Remove dead assignmenthw/ | +1 | 0 replies | |
| 5/9 | hw/ide/sii3112: Remove dead assignmenthw/ | +3 | 0 replies | |
| 6/9 | hw/isa/i82378: Remove dead assignmenthw/ | +4 | 0 replies | |
| 7/9 | hw/gpio/aspeed_gpio: Remove dead assignmenthw/ | +1 | 0 replies | |
| 8/9 | hw/timer/stm32f2xx_timer: Remove dead assignmenthw/ | +0 | 0 replies | |
| 9/9 | hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warninghw/ | +1 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Alistair Francis | David Gibson | BALATON Zoltan | John Snow | Cédric Le Goater | Max Reitz |
|---|---|---|---|---|---|---|
| 1/9 | R-b | R-b | ||||
| 2/9 | R-b | |||||
| 3/9 | R-b | |||||
| 4/9 | A-b | |||||
| 5/9 | R-b | A-b | ||||
| 6/9 | R-b | |||||
| 7/9 | R-b | |||||
| 8/9 | R-b | |||||
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v3 0/9] misc: Trivial static code analyzer fixes
Fix trivial warnings reported by the Clang static code analyzer.
Only patch #2 'blockdev: Remove dead assignment' misses review.
The official Clang static code analyzer documentation is on:
https://clang-analyzer.llvm.org/
On Fedora I simply used it as:
$ sudo dnf install clang-analyzer $ ../configure $ scan-build make
Since v2:
- Based on lvivier/trivial-patches-for-5.1
- Removed dup patches from Kuhn Chenqun Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments
Philippe Mathieu-Daudé (9):
block: Avoid dead assignment
blockdev: Remove dead assignment
hw/i2c/pm_smbus: Remove dead assignment
hw/input/adb-kbd: Remove dead assignment
hw/ide/sii3112: Remove dead assignment
hw/isa/i82378: Remove dead assignment
hw/gpio/aspeed_gpio: Remove dead assignment hw/timer/stm32f2xx_timer: Remove dead assignment hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
block.c | 2 +- blockdev.c | 2 +- hw/gpio/aspeed_gpio.c | 2 +- hw/i2c/pm_smbus.c | 1 - hw/ide/sii3112.c | 5 +++-- hw/input/adb-kbd.c | 6 +----- hw/isa/i82378.c | 8 ++++---- hw/timer/pxa2xx_timer.c | 1 + hw/timer/stm32f2xx_timer.c | 1 - 9 files changed, 12 insertions(+), 16 deletions(-)
Signature · 1 line
2.21.1