Skip to content

misc: Trivial static code analyzer fixes

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-trivial 3 versions – Applied

Status from this message: Applied to my trivial-patches branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 4 repliesApplied
  2. v211 patches 16 repliesSuperseded
  3. v111 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Based on lvivier/trivial-patches-for-5.1
- Removed dup patches from Kuhn Chenqun Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/9block: Avoid dead assignmentblock.c+1 -11 reply
2/9blockdev: Remove dead assignmentblockdev.c+1 -11 reply
3/9hw/i2c/pm_smbus: Remove dead assignmenthw/i2c/pm_smbus.c+0 -10 replies
4/9hw/input/adb-kbd: Remove dead assignmenthw/input/adb-kbd.c+1 -50 replies
5/9hw/ide/sii3112: Remove dead assignmenthw/ide/sii3112.c+3 -20 replies
6/9hw/isa/i82378: Remove dead assignmenthw/isa/i82378.c+4 -40 replies
7/9hw/gpio/aspeed_gpio: Remove dead assignmenthw/gpio/aspeed_gpio.c+1 -10 replies
8/9hw/timer/stm32f2xx_timer: Remove dead assignmenthw/timer/stm32f2xx_timer.c+0 -10 replies
9/9hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warninghw/timer/pxa2xx_timer.c+1 -00 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisDavid GibsonBALATON ZoltanJohn SnowCédric Le GoaterMax Reitz
1/9R-b R-b
2/9R-b
3/9R-b
4/9A-b
5/9R-b A-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/9] misc: Trivial static code analyzer fixes

Fix trivial warnings reported by the Clang static code analyzer.

Only patch #2 'blockdev: Remove dead assignment' misses review.

The official Clang static code analyzer documentation is on:
https://clang-analyzer.llvm.org/

On Fedora I simply used it as:

  $ sudo dnf install clang-analyzer
  $ ../configure
  $ scan-build make

Since v2:
- Based on lvivier/trivial-patches-for-5.1
- Removed dup patches from Kuhn Chenqun Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments

Philippe Mathieu-Daudé (9):
block: Avoid dead assignment
blockdev: Remove dead assignment
hw/i2c/pm_smbus: Remove dead assignment
hw/input/adb-kbd: Remove dead assignment
hw/ide/sii3112: Remove dead assignment
hw/isa/i82378: Remove dead assignment
hw/gpio/aspeed_gpio: Remove dead assignment hw/timer/stm32f2xx_timer: Remove dead assignment hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning

 block.c                    | 2 +-
 blockdev.c                 | 2 +-
 hw/gpio/aspeed_gpio.c      | 2 +-
 hw/i2c/pm_smbus.c          | 1 -
 hw/ide/sii3112.c           | 5 +++--
 hw/input/adb-kbd.c         | 6 +-----
 hw/isa/i82378.c            | 8 ++++----
 hw/timer/pxa2xx_timer.c    | 1 +
 hw/timer/stm32f2xx_timer.c | 1 -
 9 files changed, 12 insertions(+), 16 deletions(-)
Signature · 1 line
2.21.1