Skip to content

COLO: Fix memory leak in packet_enqueue()

Derek Su qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest1 patch 6 repliesIn review

Changes in v2 from the cover letter

- Fix incorrect patch format

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1net/colo-compare.c: Fix memory leak in packet_enqueue()net/colo-compare.c+15 -86 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] COLO: Fix memory leak in packet_enqueue()

The patch is to fix the memory leak in packet_enqueue(). The allocated "pkt" needs to be freed if the colo compare primary or secondary queue is too big to insert.

Reproduce steps:
(1) Setup PVM and SVM both with NIC e1000 by the steps descripted in the wiki qemu/COLO
(2) Run "iperf3 -s" in PVM
(3) Run "iperfs -c <PVM-IP> -t 7200"

The memory usage of qemu-system-x86_64 increases as the PVM's QMP shows "qemu-system-x86_64: colo compare secondary queue size too big, drop packet".

Please review, thanks.

V2:
- Fix incorrect patch format

Derek Su (1):
net/colo-compare.c: Fix memory leak in packet_enqueue()

 net/colo-compare.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1