Skip to content

x86: remove always-defined CONFIG_AS_* options

Masahiro Yamada linux-crypto lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 5 repliesIn review
  2. v17 patches 17 repliesSuperseded

Changes in v2 from the cover letter

- New patch
- Remove CFI_SIGNAL_FRAME entirely (per Nick)
- add ifdef CONFIG_X86 to fix build errors on non-x86 arches

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9lib/raid6/test: fix build on distros whose /bin/sh is not bashlib/raid6/test/Makefile+3 -31 reply
2/9x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.harch/x86/include/asm/dwarf2.h+1 -10 replies
3/9x86: remove always-defined CONFIG_AS_CFIarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -440 replies
4/9x86: remove unneeded (CONFIG_AS_)CFI_SIGNAL_FRAMEarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -100 replies
5/9x86: remove always-defined CONFIG_AS_CFI_SECTIONSarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -60 replies
6/9x86: remove always-defined CONFIG_AS_SSSE3arch/x86/Makefile arch/x86/crypto/blake2s-core.S lib/raid6/algos.c +2 more+4 -150 replies
7/9x86: remove always-defined CONFIG_AS_AVXarch/x86/Makefile arch/x86/crypto/Makefile arch/x86/crypto/aesni-intel_avx-x86_64.S +10 more+21 -890 replies
8/9x86: add comments about the binutils version to support code in as-instrarch/x86/Makefile+5 -00 replies
9/9x86: replace arch macros from compiler with CONFIG_X86_{32,64}kernel/signal.c lib/raid6/algos.c+3 -31 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJason A. DonenfeldNick DesaulniersH. Peter Anvin (Intel)
1/9A-b
2/9A-b
3/9A-b R-b
4/9A-b
5/9A-b R-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] x86: remove always-defined CONFIG_AS_* options

arch/x86/Makefile tests instruction code by $(call as-instr, ...)

Some of them are very old.
For example, the check for CONFIG_AS_CFI dates back to 2006.

We raise GCC versions from time to time, and we clean old code away. The same policy applied to binutils.

The current minimal supported version of binutils is 2.21

This is new enough to recognize the instruction in most of as-instr calls.

If this series looks good, how to merge it?
Via x86 tree or maybe crypto ?

Changes in v2:
- New patch
- Remove CFI_SIGNAL_FRAME entirely (per Nick)
- add ifdef CONFIG_X86 to fix build errors on non-x86 arches

Masahiro Yamada (9):
lib/raid6/test: fix build on distros whose /bin/sh is not bash
x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h
x86: remove always-defined CONFIG_AS_CFI
x86: remove unneeded (CONFIG_AS_)CFI_SIGNAL_FRAME
x86: remove always-defined CONFIG_AS_CFI_SECTIONS
x86: remove always-defined CONFIG_AS_SSSE3
x86: remove always-defined CONFIG_AS_AVX
x86: add comments about the binutils version to support code in
as-instr
x86: replace arch macros from compiler with CONFIG_X86_{32,64}

 arch/x86/Makefile                             | 21 +++------
 arch/x86/crypto/Makefile                      | 32 +++++---------
 arch/x86/crypto/aesni-intel_avx-x86_64.S      |  3 --
 arch/x86/crypto/aesni-intel_glue.c            | 14 +-----
 arch/x86/crypto/blake2s-core.S                |  2 -
 arch/x86/crypto/poly1305-x86_64-cryptogams.pl |  8 ----
 arch/x86/crypto/poly1305_glue.c               |  6 +--
 arch/x86/crypto/sha1_ssse3_asm.S              |  4 --
 arch/x86/crypto/sha1_ssse3_glue.c             |  9 +---
 arch/x86/crypto/sha256-avx-asm.S              |  3 --
 arch/x86/crypto/sha256_ssse3_glue.c           |  8 +---
 arch/x86/crypto/sha512-avx-asm.S              |  2 -
 arch/x86/crypto/sha512_ssse3_glue.c           |  7 +--
 arch/x86/include/asm/dwarf2.h                 | 44 -------------------
 arch/x86/include/asm/xor_avx.h                |  9 ----
 kernel/signal.c                               |  2 +-
 lib/raid6/algos.c                             |  6 +--
 lib/raid6/recov_ssse3.c                       |  6 ---
 lib/raid6/test/Makefile                       |  8 ++--
 19 files changed, 33 insertions(+), 161 deletions(-)
Signature · 1 line
2.17.1