scsi: target: XCOPY performance
Status from this message: Applied to 5.7/scsi-queue, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 1 replyApplied
- v25 patches 2 repliesSuperseded
- v1 RFC5 patches 6 repliesSuperseded
Changes in v3 from the cover letter
- 5/5: incorporate Christoph's clean up suggestions
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | scsi: target: use #def for xcopy descriptor lendrivers/ | +1 | 0 replies | |
| 2/5 | scsi: target: drop xcopy DISK BLOCK LENGTH debugdrivers/ drivers/ | +0 | 0 replies | |
| 3/5 | scsi: target: avoid per-loop XCOPY buffer allocationsdrivers/ drivers/ | +31 | 0 replies | |
| 4/5 | scsi: target: increase XCOPY I/O sizedrivers/ | +1 | 0 replies | |
| 5/5 | scsi: target: use the stack for XCOPY passthrough cmdsdrivers/ drivers/ | +31 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/5] scsi: target: XCOPY performance
These changes remove unnecessary heap allocations in the XCOPY READ/WRITE dispatch loop.
Synthetic benchmarks on my laptop using the libiscsi iscsi-dd utility (--xcopy --max 1 --blocks 65535 src=dst) against a target backed by an 8G zram (DEBUG_KMEMLEAK=y) iblock backstore (avg across four runs) show:
before: 5.30845G/s after: 5.99056G/s (approx. +12.8%)
Changes since v2:
- 5/5: incorporate Christoph's clean up suggestions
Changes since v1:
- drop RFC
- rework 3/5 and 5/5 following Christoph's feedback
Feedback appreciated.
Cheers, David
----------------------------------------------------------------
David Disseldorp (5):
scsi: target: use #def for xcopy descriptor len
scsi: target: drop xcopy DISK BLOCK LENGTH debug
scsi: target: avoid per-loop XCOPY buffer allocations
scsi: target: increase XCOPY I/O size
scsi: target: use the stack for XCOPY passthrough cmds
drivers/target/target_core_xcopy.c | 187 ++++++++++------------------- drivers/target/target_core_xcopy.h | 9 +- 2 files changed, 64 insertions(+), 132 deletions(-)