Skip to content

gpio: mpc8xxx: honour shadow register when writing gpdat

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20200323204547.GM5793@bill-the-cat

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpio: mpc8xxx: don't modify gpdat when setting gpio as input+0 -00 replies
2/2gpio: mpc8xxx: don't do RMW on gpdat register when setting value+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat
Quoted 9 lines · Rasmus Villemoes
Quoted 8 lines · Rasmus Villemoes
Quoted 6 lines · Rasmus Villemoes

[resending with Mario's correct address, sorry for the double post]

The driver correctly uses the shadow register when asked for the current value of an output gpio. Unfortunately, it does RMW on the gpdat register both when setting a gpio as input and output. These two patches fix that.

Quoted 6 lines
Quoted 1 line

Ping. Any chance these fixes can make it to 2020.04 ?

Ping^3.

Tom, will you consider applying these directly? It's been two months and I haven't got any response. Or advise on what I could do.

I suppose that if Mario doesn't speak up soon I'll take a look at picking them up myself, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200323/9a10aa63/attachment.sig>