Skip to content

AMDGPU / RADEON / DRM Fix mapping of user pages

Shane Francis dri-devel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 18 repliesIn review
  2. v33 patches 1 replySuperseded
  3. v23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/prime: use dma length macro when mapping sgdrivers/gpu/drm/drm_prime.c+1 -113 replies
2/3drm/amdgpu: fix scatter-gather mapping with user pagesdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+1 -11 reply
3/3drm/radeon: fix scatter-gather mapping with user pagesdrivers/gpu/drm/radeon/radeon_ttm.c+1 -13 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMichael J. Ruhl
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] AMDGPU / RADEON / DRM Fix mapping of user pages

This patch set is to fix a bug in amdgpu / radeon drm that results in a crash when dma_map_sg combines elemnets within a scatterlist table.

There are 2 shortfalls in the current kernel.

1) AMDGPU / RADEON assumes that the requested and created scatterlist table lengths using from dma_map_sg are equal. This may not be the case using the newer dma-iommu implementation

2) drm_prime does not fetch the length of the scatterlist via the correct dma macro, this can use the incorrect length being used (>0) in places where dma_map_sg has updated the table elements.

The sg_dma_len macro is representative of the length of the sg item after dma_map_sg

Example Crash :

Quoted 1 line

[drm:amdgpu_ttm_backend_bind [amdgpu]] *ERROR* failed to pin userptr

This happens in OpenCL applications, causing them to crash or hang, on either amdgpu-pro or ROCm OpenCL implementations

I have verified this fixes the above on kernel 5.5 and 5.5rc using an AMD Vega 64 GPU

Shane Francis (3):
drm/prime: use dma length macro when mapping sg to arrays drm/amdgpu: fix scatter-gather mapping with user pages drm/radeon: fix scatter-gather mapping with user pages

 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
 drivers/gpu/drm/drm_prime.c             | 2 +-
 drivers/gpu/drm/radeon/radeon_ttm.c     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 6 lines
2.26.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel