net: ks8851: Unify KS8851 SPI and MLL drivers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest19 patches 7 repliesIn review
- v620 patches 21 repliesSuperseded
- v519 patches 23 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 19 patches | 11 replies | Superseded | |
| v3 | 18 patches | 10 replies | Superseded | |
| v2 | 14 patches | 7 replies | Superseded | |
| v1 | 14 patches | 36 replies | Superseded |
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | net: ks8851: Factor out spi->dev in probe()/remove()drivers/ | +14 | 0 replies | |
| 2/19 | net: ks8851: Rename ndev to netdev in probedrivers/ | +15 | 0 replies | |
| 3/19 | net: ks8851: Replace dev_err() with netdev_err() in IRQ handlerdrivers/ | +1 | 0 replies | |
| 4/19 | net: ks8851: Pass device node into ks8851_init_mac()drivers/ | +4 | 1 reply | |
| 5/19 | net: ks8851: Use devm_alloc_etherdev()drivers/ | +4 | 0 replies | |
| 6/19 | net: ks8851: Use dev_{get,set}_drvdata()drivers/ | +4 | 0 replies | |
| 7/19 | net: ks8851: Remove ks8851_rdreg32()drivers/ | +2 | 1 reply | |
| 8/19 | net: ks8851: Use 16-bit writes to program MAC addressdrivers/ drivers/ | +14 | 0 replies | |
| 9/19 | net: ks8851: Use 16-bit read of RXFC registerdrivers/ | +1 | 1 reply | |
| 10/19 | net: ks8851: Factor out bus lock handlingdrivers/ | +68 | 0 replies | |
| 11/19 | net: ks8851: Factor out SKB receive functiondrivers/ | +10 | 1 reply | |
| 12/19 | net: ks8851: Split out SPI specific entries in struct ks8851_netdrivers/ | +79 | 0 replies | |
| 13/19 | net: ks8851: Split out SPI specific code from probe() and remove()drivers/ | +48 | 0 replies | |
| 14/19 | net: ks8851: Factor out TX work flush functiondrivers/ | +12 | 0 replies | |
| 15/19 | net: ks8851: Permit overridding interrupt enable registerdrivers/ | +11 | 0 replies | |
| 16/19 | net: ks8851: Implement register, FIFO, lock accessor callbacksdrivers/ | +156 | 0 replies | |
| 17/19 | net: ks8851: Separate SPI operations into separate filedrivers/ drivers/ drivers/ +1 more | +642 | 0 replies | |
| 18/19 | net: ks8851: Implement Parallel bus operationsdrivers/ drivers/ drivers/ | +360 | 1 reply | |
| 19/19 | net: ks8851: Remove ks8851_mll.cdrivers/ | +0 | 1 reply |
Reviews trailers per patch
18 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Andrew Lunn |
|---|---|
| 1/19 | R-b |
| 2/19 | R-b |
| 3/19 | R-b |
| 4/19 | R-b |
| 5/19 | R-b |
| 6/19 | R-b |
| 7/19 | R-b |
| 8/19 | R-b |
| 9/19 | R-b |
| 10/19 | R-b |
| 11/19 | R-b |
| 12/19 | R-b |
| 13/19 | R-b |
| 14/19 | R-b |
| 15/19 | R-b |
| 16/19 | R-b |
| 17/19 | |
| 18/19 | R-b |
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V7 00/19] net: ks8851: Unify KS8851 SPI and MLL drivers
The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces of silicon, except the former has an SPI interface, while the later has a parallel bus interface. Thus far, Linux has two separate drivers for each and they are diverging considerably.
This series unifies them into a single driver with small SPI and parallel bus specific parts. The approach here is to first separate out the SPI specific parts into a separate file, then add parallel bus accessors in another separate file and then finally remove the old parallel bus driver. The reason for replacing the old parallel bus driver is because the SPI bus driver is much higher quality.
Note that I dropped "net: ks8851: Drop define debug and pr_fmt()" for now, will send it separatelly later.
Marek Vasut (19):
net: ks8851: Factor out spi->dev in probe()/remove()
net: ks8851: Rename ndev to netdev in probe
net: ks8851: Replace dev_err() with netdev_err() in IRQ handler
net: ks8851: Pass device node into ks8851_init_mac()
net: ks8851: Use devm_alloc_etherdev()
net: ks8851: Use dev_{get,set}_drvdata()
net: ks8851: Remove ks8851_rdreg32()
net: ks8851: Use 16-bit writes to program MAC address
net: ks8851: Use 16-bit read of RXFC register
net: ks8851: Factor out bus lock handling
net: ks8851: Factor out SKB receive function
net: ks8851: Split out SPI specific entries in struct ks8851_net
net: ks8851: Split out SPI specific code from probe() and remove()
net: ks8851: Factor out TX work flush function
net: ks8851: Permit overridding interrupt enable register
net: ks8851: Implement register, FIFO, lock accessor callbacks
net: ks8851: Separate SPI operations into separate file
net: ks8851: Implement Parallel bus operations
net: ks8851: Remove ks8851_mll.c
drivers/net/ethernet/micrel/Kconfig | 2 +
drivers/net/ethernet/micrel/Makefile | 2 +
drivers/net/ethernet/micrel/ks8851.h | 151 +-
.../micrel/{ks8851.c => ks8851_common.c} | 698 ++-------
drivers/net/ethernet/micrel/ks8851_mll.c | 1393 -----------------
drivers/net/ethernet/micrel/ks8851_par.c | 357 +++++
drivers/net/ethernet/micrel/ks8851_spi.c | 485 ++++++
7 files changed, 1135 insertions(+), 1953 deletions(-)
rename drivers/net/ethernet/micrel/{ks8851.c => ks8851_common.c} (62%)
delete mode 100644 drivers/net/ethernet/micrel/ks8851_mll.c
create mode 100644 drivers/net/ethernet/micrel/ks8851_par.c
create mode 100644 drivers/net/ethernet/micrel/ks8851_spi.cSignature · 1 line
2.25.1