Skip to content

net: ks8851: Unify KS8851 SPI and MLL drivers

Marek Vasut netdev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest19 patches 7 repliesIn review
  2. v620 patches 21 repliesSuperseded
  3. v519 patches 23 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v419 patches11 repliesSuperseded
v318 patches10 repliesSuperseded
v214 patches7 repliesSuperseded
v114 patches36 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19net: ks8851: Factor out spi->dev in probe()/remove()drivers/net/ethernet/micrel/ks8851.c+14 -150 replies
2/19net: ks8851: Rename ndev to netdev in probedrivers/net/ethernet/micrel/ks8851.c+15 -150 replies
3/19net: ks8851: Replace dev_err() with netdev_err() in IRQ handlerdrivers/net/ethernet/micrel/ks8851.c+1 -10 replies
4/19net: ks8851: Pass device node into ks8851_init_mac()drivers/net/ethernet/micrel/ks8851.c+4 -31 reply
5/19net: ks8851: Use devm_alloc_etherdev()drivers/net/ethernet/micrel/ks8851.c+4 -90 replies
6/19net: ks8851: Use dev_{get,set}_drvdata()drivers/net/ethernet/micrel/ks8851.c+4 -20 replies
7/19net: ks8851: Remove ks8851_rdreg32()drivers/net/ethernet/micrel/ks8851.c+2 -231 reply
8/19net: ks8851: Use 16-bit writes to program MAC addressdrivers/net/ethernet/micrel/ks8851.c drivers/net/ethernet/micrel/ks8851.h+14 -350 replies
9/19net: ks8851: Use 16-bit read of RXFC registerdrivers/net/ethernet/micrel/ks8851.c+1 -161 reply
10/19net: ks8851: Factor out bus lock handlingdrivers/net/ethernet/micrel/ks8851.c+68 -290 replies
11/19net: ks8851: Factor out SKB receive functiondrivers/net/ethernet/micrel/ks8851.c+10 -11 reply
12/19net: ks8851: Split out SPI specific entries in struct ks8851_netdrivers/net/ethernet/micrel/ks8851.c+79 -490 replies
13/19net: ks8851: Split out SPI specific code from probe() and remove()drivers/net/ethernet/micrel/ks8851.c+48 -380 replies
14/19net: ks8851: Factor out TX work flush functiondrivers/net/ethernet/micrel/ks8851.c+12 -40 replies
15/19net: ks8851: Permit overridding interrupt enable registerdrivers/net/ethernet/micrel/ks8851.c+11 -110 replies
16/19net: ks8851: Implement register, FIFO, lock accessor callbacksdrivers/net/ethernet/micrel/ks8851.c+156 -220 replies
17/19net: ks8851: Separate SPI operations into separate filedrivers/net/ethernet/micrel/Makefile drivers/net/ethernet/micrel/ks8851.h drivers/net/ethernet/micrel/ks8851_common.c +1 more+642 -5970 replies
18/19net: ks8851: Implement Parallel bus operationsdrivers/net/ethernet/micrel/Kconfig drivers/net/ethernet/micrel/Makefile drivers/net/ethernet/micrel/ks8851_par.c+360 -01 reply
19/19net: ks8851: Remove ks8851_mll.cdrivers/net/ethernet/micrel/ks8851_mll.c+0 -13931 reply

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH V7 00/19] net: ks8851: Unify KS8851 SPI and MLL drivers

The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces of silicon, except the former has an SPI interface, while the later has a parallel bus interface. Thus far, Linux has two separate drivers for each and they are diverging considerably.

This series unifies them into a single driver with small SPI and parallel bus specific parts. The approach here is to first separate out the SPI specific parts into a separate file, then add parallel bus accessors in another separate file and then finally remove the old parallel bus driver. The reason for replacing the old parallel bus driver is because the SPI bus driver is much higher quality.

Note that I dropped "net: ks8851: Drop define debug and pr_fmt()" for now, will send it separatelly later.

Marek Vasut (19):
net: ks8851: Factor out spi->dev in probe()/remove()
net: ks8851: Rename ndev to netdev in probe
net: ks8851: Replace dev_err() with netdev_err() in IRQ handler
net: ks8851: Pass device node into ks8851_init_mac()
net: ks8851: Use devm_alloc_etherdev()
net: ks8851: Use dev_{get,set}_drvdata()
net: ks8851: Remove ks8851_rdreg32()
net: ks8851: Use 16-bit writes to program MAC address
net: ks8851: Use 16-bit read of RXFC register
net: ks8851: Factor out bus lock handling
net: ks8851: Factor out SKB receive function
net: ks8851: Split out SPI specific entries in struct ks8851_net
net: ks8851: Split out SPI specific code from probe() and remove()
net: ks8851: Factor out TX work flush function
net: ks8851: Permit overridding interrupt enable register
net: ks8851: Implement register, FIFO, lock accessor callbacks
net: ks8851: Separate SPI operations into separate file
net: ks8851: Implement Parallel bus operations
net: ks8851: Remove ks8851_mll.c

 drivers/net/ethernet/micrel/Kconfig           |    2 +
 drivers/net/ethernet/micrel/Makefile          |    2 +
 drivers/net/ethernet/micrel/ks8851.h          |  151 +-
 .../micrel/{ks8851.c => ks8851_common.c}      |  698 ++-------
 drivers/net/ethernet/micrel/ks8851_mll.c      | 1393 -----------------
 drivers/net/ethernet/micrel/ks8851_par.c      |  357 +++++
 drivers/net/ethernet/micrel/ks8851_spi.c      |  485 ++++++
 7 files changed, 1135 insertions(+), 1953 deletions(-)
 rename drivers/net/ethernet/micrel/{ks8851.c => ks8851_common.c} (62%)
 delete mode 100644 drivers/net/ethernet/micrel/ks8851_mll.c
 create mode 100644 drivers/net/ethernet/micrel/ks8851_par.c
 create mode 100644 drivers/net/ethernet/micrel/ks8851_spi.c
Cc David S. Miller <[email protected]>
Cc Lukas Wunner <[email protected]>
Cc Petr Stetiar <[email protected]>
Cc YueHaibing <[email protected]>
Signature · 1 line
2.25.1