Skip to content

kvm: Use rcuwait for vcpu blocking

Davidlohr Bueso kvm kvmarm linux-mips lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 7 repliesIn review
  2. v35 patches 8 repliesApplied
  3. v14 patches 4 repliesSuperseded

Changes in v4 from the cover letter

- picked up maz and peterz's acks for routing via kvm tree.
- added new patch 4/5 which introduces rcuwait_active. This is to avoid

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rcuwait: Fix stale wake call name in commentkernel/exit.c+1 -10 replies
2/5rcuwait: Let rcuwait_wake_up() return whether or not a task was awokeninclude/linux/rcuwait.h kernel/exit.c+6 -30 replies
3/5rcuwait: Introduce prepare_to and finish_rcuwaitinclude/linux/rcuwait.h+16 -50 replies
4/5rcuwait: Introduce rcuwait_active()include/linux/rcuwait.h+9 -04 replies
5/5kvm: Replace vcpu->swait with rcuwaitarch/mips/kvm/mips.c arch/powerpc/include/asm/kvm_book3s.h arch/powerpc/include/asm/kvm_host.h +8 more+36 -443 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)Marc ZyngierDavidlohr BuesoWanpeng Li
1/5A-b
2/5A-b
3/5A-b
4/5A-b A-b T-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] kvm: Use rcuwait for vcpu blocking

Hi,

The following is an updated (and hopefully final) revision of the kvm vcpu to rcuwait conversion[0], following the work on completions using simple waitqueues.

Patches 1-4 level up the rcuwait api with waitqueues. Patch 5 converts kvm to use rcuwait.

Changes from v3:
- picked up maz and peterz's acks for routing via kvm tree.
- added new patch 4/5 which introduces rcuwait_active. This is to avoid

    directly calling rcu_dereference() to peek at the wait->task.

- fixed breakage for arm in patch 4/5.
- removed previous patch 5/5 which updates swait doc as peterz will keep it.

Changes from v2:
- new patch 3 which adds prepare_to_rcuwait and finish_rcuwait helpers.
- fixed broken sleep and tracepoint semantics in patch 4. (Marc and Paolo)

This has only been run tested on x86 but compile tested on mips, powerpc and arm. It passes all tests from kvm-unit-tests[1].

This series applies on top of current kvm and tip trees. Please consider for v5.8.

[0] https://lore.kernel.org/lkml/[email protected]/
[1] git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git

Thanks!

Davidlohr Bueso (5):
rcuwait: Fix stale wake call name in comment
rcuwait: Let rcuwait_wake_up() return whether or not a task was awoken
rcuwait: Introduce prepare_to and finish_rcuwait
rcuwait: Introduce rcuwait_active()
kvm: Replace vcpu->swait with rcuwait

 arch/mips/kvm/mips.c                  |  6 ++----
 arch/powerpc/include/asm/kvm_book3s.h |  2 +-
 arch/powerpc/include/asm/kvm_host.h   |  2 +-
 arch/powerpc/kvm/book3s_hv.c          | 22 ++++++++--------------
 arch/powerpc/kvm/powerpc.c            |  2 +-
 arch/x86/kvm/lapic.c                  |  2 +-
 include/linux/kvm_host.h              | 10 +++++-----
 include/linux/rcuwait.h               | 32 ++++++++++++++++++++++++++------
 kernel/exit.c                         |  9 ++++++---
 virt/kvm/arm/arch_timer.c             |  3 ++-
 virt/kvm/arm/arm.c                    |  9 +++++----
 virt/kvm/async_pf.c                   |  3 +--
 virt/kvm/kvm_main.c                   | 19 +++++++++----------
 13 files changed, 68 insertions(+), 53 deletions(-)

--
2.16.4