Skip to content

s390x: smp: Improve smp code part 2

Janosch Frank kvm linux-s390 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/210 patches 6 repliesIn review
  2. v3 posting 1/21 patch 1 replySuperseded
  3. v210 patches 21 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches19 repliesSuperseded

Changes in v3 from the cover letter

* Added some rev-bys and acks
* Add a workaround for stop and store status
* Beautified cr checking with loop

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10s390x: smp: Test all CRs on initial resets390x/smp.c+17 -10 replies
2/10s390x: smp: Dirty fpc before initial reset tests390x/smp.c+1 -00 replies
3/10s390x: smp: Test stop and store status on a running and stopped cpus390x/smp.c+14 -00 replies
4/10s390x: smp: Test local interrupts after cpu resets390x/smp.c+21 -01 reply
5/10s390x: smp: Loop if secondary cpu returns into cpu setup agains390x/cstart64.S+3 -11 reply
6/10s390x: smp: Remove unneeded cpu loopss390x/smp.c+1 -70 replies
7/10s390x: smp: Use full PSW to bringup new cpulib/s390x/smp.c s390x/cstart64.S+4 -10 replies
8/10s390x: smp: Wait for sigp completionlib/s390x/smp.c lib/s390x/smp.h s390x/smp.c+20 -23 replies
9/10s390x: smp: Add restart when running tests390x/smp.c+29 -00 replies
10/10s390x: Fix library constant definitionslib/s390x/asm/arch_def.h+4 -40 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckChristian BorntraegerDavid HildenbrandThomas Huth
1/10R-b R-b R-b
2/10R-b R-b R-b
3/10R-b R-b
4/10R-b A-b
5/10R-b A-b
6/10R-b A-b
7/10R-b R-b
8/10R-b
9/10R-b R-b
10/10R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] s390x: smp: Improve smp code part 2

Let's continue cleaning up the smp test and smp related functions.

We add:
* Test for external/emergency calls after reset
* Test SIGP restart while running
* SIGP stop and store status while running
* CR testing on reset

We fix:
* Proper check for sigp completion
* smp_cpu_setup_state() loop and return address in r14

v3:
* Added some rev-bys and acks
* Add a workaround for stop and store status
* Beautified cr checking with loop

v2:
* Added some rev-bys and acks
* Explicitly stop and start cpu before hot restart test

GIT: https://github.com/frankjaa/kvm-unit-tests/tree/smp_cleanup2

Janosch Frank (10):
s390x: smp: Test all CRs on initial reset
s390x: smp: Dirty fpc before initial reset test
s390x: smp: Test stop and store status on a running and stopped cpu
s390x: smp: Test local interrupts after cpu reset
s390x: smp: Loop if secondary cpu returns into cpu setup again
s390x: smp: Remove unneeded cpu loops
s390x: smp: Use full PSW to bringup new cpu
s390x: smp: Wait for sigp completion
s390x: smp: Add restart when running test
s390x: Fix library constant definitions

 lib/s390x/asm/arch_def.h |   8 ++--
 lib/s390x/smp.c          |  11 +++++
 lib/s390x/smp.h          |   1 +
 s390x/cstart64.S         |   5 +-
 s390x/smp.c              | 101 +++++++++++++++++++++++++++++++++++----
 5 files changed, 112 insertions(+), 14 deletions(-)
Signature · 1 line
2.25.1