Skip to content

x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

Masahiro Yamada dri-devel intel-gfx linux-crypto linux-doc linux-kbuild lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 15 repliesIn review
  2. v116 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16lib/raid6/test: fix build on distros whose /bin/sh is not bashlib/raid6/test/Makefile+3 -30 replies
2/16x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.harch/x86/include/asm/dwarf2.h+1 -10 replies
3/16x86: remove always-defined CONFIG_AS_CFIarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -440 replies
4/16x86: remove unneeded (CONFIG_AS_)CFI_SIGNAL_FRAMEarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -100 replies
5/16x86: remove always-defined CONFIG_AS_CFI_SECTIONSarch/x86/Makefile arch/x86/include/asm/dwarf2.h+2 -60 replies
6/16x86: remove always-defined CONFIG_AS_SSSE3arch/x86/Makefile arch/x86/crypto/blake2s-core.S lib/raid6/algos.c +2 more+4 -150 replies
7/16x86: remove always-defined CONFIG_AS_AVXarch/x86/Makefile arch/x86/crypto/Makefile arch/x86/crypto/aesni-intel_avx-x86_64.S +10 more+21 -890 replies
8/16x86: replace arch macros from compiler with CONFIG_X86_{32,64}kernel/signal.c lib/raid6/algos.c+3 -32 replies
9/16drm/i915: remove always-defined CONFIG_AS_MOVNTDQAdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/i915_memcpy.c+0 -81 reply
10/16x86: probe assembler capabilities via kconfig instead of makefilearch/x86/Kconfig arch/x86/Kconfig.assembler arch/x86/Makefile+19 -103 replies
11/16x86: add comments about the binutils version to support code in as-instrarch/x86/Kconfig.assembler+10 -01 reply
12/16crypto: x86 - rework configuration based on Kconfigarch/x86/crypto/Makefile crypto/Kconfig+69 -910 replies
13/16crypto: curve25519 - do not pollute dispatcher based on assemblerinclude/crypto/curve25519.h+2 -40 replies
14/16Documentation/changes: Raise minimum supported binutils version to 2.23Documentation/process/changes.rst+2 -20 replies
15/16x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2arch/x86/Kconfig.assembler arch/x86/crypto/Makefile arch/x86/crypto/aesni-intel_avx-x86_64.S +14 more+10 -856 replies
16/16crypto: x86 - clean up poly1305-x86_64-cryptogams.S by 'make clean'arch/x86/crypto/Makefile+0 -20 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNick DesaulniersH. Peter Anvin (Intel)Jason A. DonenfeldKees CookHerbert XuIngo Molnar
SeriesR-b A-b
1/16A-b
2/16R-b A-b
3/16R-b A-b
4/16R-b A-b
5/16R-b A-b
6/16R-b A-b
7/16A-b
8/16A-b
9/16R-b
10/16R-b
11/16A-b A-b
12/16A-b
13/16A-b
14/16A-b A-b A-b
15/16R-b
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

This series of cleanups was prompted by Linus:
https://lkml.org/lkml/2020/3/12/726

First, this series drop always-on CONFIG_AS_* options. Some of those options were introduced in old days. For example, the check for CONFIG_AS_CFI dates back to 2006.

We raise the minimal tool versions from time to time. Currently, we require binutils 2.21
(and we even plan to bump it to 2.23).

After cleaning away the old checks, as-instr calls are moved to Kconfig from Makefiles, then more Kconfig / Makefile code is cleaned up.

I folded all relevanet patches into this series,
as suggested by Jason A. Donenfeld.

The update for v2 is quite small.
I just swapped the patch order of patch 8 and 11
instead of moving comments around files,
which was addressed by Nick Desaulniers.

Borislav Petkov (1):
Documentation/changes: Raise minimum supported binutils version to

    2.23

Jason A. Donenfeld (4):
x86: probe assembler capabilities via kconfig instead of makefile
crypto: x86 - rework configuration based on Kconfig
crypto: curve25519 - do not pollute dispatcher based on assembler
x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2

Masahiro Yamada (11):
lib/raid6/test: fix build on distros whose /bin/sh is not bash
x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h
x86: remove always-defined CONFIG_AS_CFI
x86: remove unneeded (CONFIG_AS_)CFI_SIGNAL_FRAME
x86: remove always-defined CONFIG_AS_CFI_SECTIONS
x86: remove always-defined CONFIG_AS_SSSE3
x86: remove always-defined CONFIG_AS_AVX
x86: replace arch macros from compiler with CONFIG_X86_{32,64} drm/i915: remove always-defined CONFIG_AS_MOVNTDQA
x86: add comments about the binutils version to support code in
as-instr
crypto: x86 - clean up poly1305-x86_64-cryptogams.S by 'make clean'

 Documentation/process/changes.rst             |   4 +-
 arch/x86/Kconfig                              |   2 +
 arch/x86/Kconfig.assembler                    |  17 ++
 arch/x86/Makefile                             |  22 ---
 arch/x86/crypto/Makefile                      | 162 +++++++-----------
 arch/x86/crypto/aesni-intel_avx-x86_64.S      |   6 -
 arch/x86/crypto/aesni-intel_glue.c            |  21 +--
 arch/x86/crypto/blake2s-core.S                |   2 -
 arch/x86/crypto/chacha_glue.c                 |   6 +-
 arch/x86/crypto/poly1305-x86_64-cryptogams.pl |  16 --
 arch/x86/crypto/poly1305_glue.c               |  11 +-
 arch/x86/crypto/sha1_ssse3_asm.S              |   4 -
 arch/x86/crypto/sha1_ssse3_glue.c             |  13 --
 arch/x86/crypto/sha256-avx-asm.S              |   3 -
 arch/x86/crypto/sha256-avx2-asm.S             |   3 -
 arch/x86/crypto/sha256_ssse3_glue.c           |  12 --
 arch/x86/crypto/sha512-avx-asm.S              |   2 -
 arch/x86/crypto/sha512-avx2-asm.S             |   3 -
 arch/x86/crypto/sha512_ssse3_glue.c           |  10 --
 arch/x86/include/asm/dwarf2.h                 |  44 -----
 arch/x86/include/asm/xor_avx.h                |   9 -
 drivers/gpu/drm/i915/Makefile                 |   3 -
 drivers/gpu/drm/i915/i915_memcpy.c            |   5 -
 include/crypto/curve25519.h                   |   6 +-
 kernel/signal.c                               |   2 +-
 lib/raid6/algos.c                             |  12 +-
 lib/raid6/avx2.c                              |   4 -
 lib/raid6/recov_avx2.c                        |   6 -
 lib/raid6/recov_ssse3.c                       |   6 -
 lib/raid6/test/Makefile                       |   9 +-
 30 files changed, 101 insertions(+), 324 deletions(-)
 create mode 100644 arch/x86/Kconfig.assembler
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel