Skip to content

pc-bios: s390x: Cleanup part 1

Janosch Frank qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 17 repliesIn review
  2. v49 patches 7 repliesSuperseded
  3. v39 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches21 repliesSuperseded
v18 patches19 repliesSuperseded

Changes in v5 from the cover letter

* Fixed whitespace damage
* Removed reset PSW mask changes in dasd-ipl.c
* Added jump2ipl.c cleanup patches

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12pc-bios: s390x: cio.c cleanup and compile fixpc-bios/s390-ccw/cio.c+22 -181 reply
2/12pc-bios: s390x: Consolidate timing functions into time.hpc-bios/s390-ccw/menu.c pc-bios/s390-ccw/netmain.c pc-bios/s390-ccw/s390-ccw.h +4 more+36 -311 reply
3/12pc-bios: s390x: Move sleep and yield to helper.hpc-bios/s390-ccw/helper.h pc-bios/s390-ccw/s390-ccw.h pc-bios/s390-ccw/virtio-net.c +1 more+19 -180 replies
4/12pc-bios: s390x: Get rid of magic offsets into the lowcorepc-bios/s390-ccw/cio.h pc-bios/s390-ccw/main.c+14 -112 replies
5/12pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changespc-bios/s390-ccw/dasd-ipl.c+0 -32 replies
6/12pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64pc-bios/s390-ccw/s390-arch.h+1 -11 reply
7/12pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDRpc-bios/s390-ccw/jump2ipl.c pc-bios/s390-ccw/s390-arch.h+6 -61 reply
8/12pc-bios: s390x: Move panic() into header and add infinite looppc-bios/s390-ccw/main.c pc-bios/s390-ccw/netmain.c pc-bios/s390-ccw/s390-ccw.h +1 more+10 -190 replies
9/12pc-bios: s390x: Use ebcdic2ascii tablepc-bios/s390-ccw/bootmap.c+1 -30 replies
10/12pc-bios: s390x: Make u32 ptr check explicitpc-bios/s390-ccw/helper.h+1 -10 replies
11/12pc-bios: s390x: Fix bootmap.c passing PSWs as addressespc-bios/s390-ccw/bootmap.c pc-bios/s390-ccw/bootmap.h+4 -32 replies
12/12pc-bios: s390x: Cleanup jump to ipl codepc-bios/s390-ccw/jump2ipl.c+11 -162 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerThomas HuthDavid HildenbrandPierre MorelCornelia Huck
1/12R-b R-b R-b R-b R-b
2/12A-b R-b
3/12R-b R-b R-b
4/12R-b R-b R-b
5/12
6/12R-b
7/12R-b R-b
8/12R-b R-b R-b
9/12R-b R-b
10/12R-b R-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

The bios is in dire need for a cleanup as there are still a lot of magic constants being used throughout as well as duplicated code.

In the first part of this series we consolidate constants and functions, as well as doing some minor cleanups and fixes.

The patches are available here:
https://github.com/frankjaa/qemu/pull/new/cleanup_bios

v5:
* Fixed whitespace damage
* Removed reset PSW mask changes in dasd-ipl.c
* Added jump2ipl.c cleanup patches

v4:
* Renamed time.h to s390-time.h
* Fixed function names in sleep()
* Changed order of sense_id_ccw initialization
* Added missing include before sleep()

v3:
* Dropped 0x00 to 0x0/0 patch
* Moved some timing functions into helper.h instead of time.h
* Fixed IPL psw manipulation in dasd-ipl.c
* Minor cosmetic fixes found by review

v2:
* Included cio fixup to get rid of compile errors...
* Minor cosmetic fixes found by review

Janosch Frank (12):
pc-bios: s390x: cio.c cleanup and compile fix
pc-bios: s390x: Consolidate timing functions into time.h
pc-bios: s390x: Move sleep and yield to helper.h
pc-bios: s390x: Get rid of magic offsets into the lowcore
pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes
pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
pc-bios: s390x: Use PSW masks where possible and introduce
PSW_MASK_SHORT_ADDR
pc-bios: s390x: Move panic() into header and add infinite loop
pc-bios: s390x: Use ebcdic2ascii table
pc-bios: s390x: Make u32 ptr check explicit
pc-bios: s390x: Fix bootmap.c passing PSWs as addresses
pc-bios: s390x: Cleanup jump to ipl code

 pc-bios/s390-ccw/bootmap.c     |  9 ++++----
 pc-bios/s390-ccw/bootmap.h     |  2 +-
 pc-bios/s390-ccw/cio.c         | 40 +++++++++++++++++++---------------
 pc-bios/s390-ccw/cio.h         | 17 ++++++++++-----
 pc-bios/s390-ccw/dasd-ipl.c    |  3 ---
 pc-bios/s390-ccw/helper.h      | 19 +++++++++++++++-
 pc-bios/s390-ccw/jump2ipl.c    | 35 ++++++++++++-----------------
 pc-bios/s390-ccw/main.c        | 15 +++----------
 pc-bios/s390-ccw/menu.c        |  1 +
 pc-bios/s390-ccw/netmain.c     | 23 +++----------------
 pc-bios/s390-ccw/s390-arch.h   |  4 +++-
 pc-bios/s390-ccw/s390-ccw.h    | 27 ++++++-----------------
 pc-bios/s390-ccw/s390-time.h   | 23 +++++++++++++++++++
 pc-bios/s390-ccw/start.S       |  5 +++--
 pc-bios/s390-ccw/virtio-net.c  |  2 ++
 pc-bios/s390-ccw/virtio-scsi.c |  2 ++
 pc-bios/s390-ccw/virtio.c      | 18 +++------------
 17 files changed, 120 insertions(+), 125 deletions(-)
 create mode 100644 pc-bios/s390-ccw/s390-time.h
Signature · 1 line
2.25.1