Skip to content

arm64: Make NOP handling a whitelist

Mark Brown linux-arm-kernel 4 versions – Applied

Status from this message: Applied to arm64 (for-next/insn), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesApplied
  2. v33 patches 3 repliesSuperseded
  3. v23 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches3 repliesSuperseded

Changes in v4 from the cover letter

- Add a patch renaming _is_nop() to make the usage clearer.
- Reorder series and tweak commit logs.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4arm64: insn: Add constants for new HINT instruction decodearch/arm64/include/asm/insn.h arch/arm64/kernel/insn.c+27 -31 reply
2/4arm64: insn: Provide a better name for aarch64_insn_is_nop()arch/arm64/include/asm/insn.h arch/arm64/kernel/insn.c arch/arm64/kernel/probes/decode-insn.c+3 -41 reply
3/4arm64: insn: Don't assume unrecognized HINTs are skippablearch/arm64/kernel/insn.c+3 -71 reply
4/4arm64: insn: Report PAC and BTI instructions as skippablearch/arm64/kernel/insn.c+17 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchCatalin MarinasMark Rutland
1/4A-b A-b
2/4A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] arm64: Make NOP handling a whitelist

Currently we default to assuming any unrecognized instruction in the hint space can be safely handled as a NOP. This is not robust and any code that really wants a NOP should be using the explicitly defined NOP so let's instead invert this and whitelist those instructions which it is safe to handle as NOPs.

Patch 1 adds defines for the HINTs for BTI landing pads which will be used by the in-kernel BTI series to generate landing pads in JITed BPF code so it'd be good if this could be applied on or merged into the BTI branch.

v4:
- Add a patch renaming _is_nop() to make the usage clearer.
- Reorder series and tweak commit logs.
v3:
- Correct values for more of the HINTs.
- Add constants for additional HINTs
- Handle XPACLRI as a NOP along with all the other PAC HINTs.
- Update commit messages for greater clarity.
- Tweak the comment about what a NOP.
v2:
- Fix values for BTI HINTs.
- Rebase on v5.7-rc3+for-next/bti-user

Mark Brown (4):
arm64: insn: Add constants for new HINT instruction decode
arm64: insn: Provide a better name for aarch64_insn_is_nop()
arm64: insn: Don't assume unrecognized HINTs are skippable
arm64: insn: Report PAC and BTI instructions as skippable

 arch/arm64/include/asm/insn.h          | 30 +++++++++++++++++++++---
 arch/arm64/kernel/insn.c               | 32 ++++++++++++++++++--------
 arch/arm64/kernel/probes/decode-insn.c |  2 +-
 3 files changed, 50 insertions(+), 14 deletions(-)
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel