Skip to content

igc: Align log messages

Andre Guedes intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10igc: Use netdev log helpers in igc_main.cdrivers/net/ethernet/intel/igc/igc_main.c+59 -701 reply
2/10igc: Use netdev log helpers in igc_ethtool.cdrivers/net/ethernet/intel/igc/igc_ethtool.c+22 -261 reply
3/10igc: Use netdev log helpers in igc_ptp.cdrivers/net/ethernet/intel/igc/igc_ptp.c+5 -71 reply
4/10igc: Use netdev log helpers in igc_dump.cdrivers/net/ethernet/intel/igc/igc_dump.c+54 -551 reply
5/10igc: Use netdev log helpers in igc_base.cdrivers/net/ethernet/intel/igc/igc_base.c+8 -81 reply
6/10igc: Use netdev log helpers in igc_diag.cdrivers/net/ethernet/intel/igc/igc_diag.c+11 -111 reply
7/10igc: Remove '\n' from log strings in igc_i225.cdrivers/net/ethernet/intel/igc/igc_i225.c+11 -111 reply
8/10igc: Remove '\n' from log strings in igc_mac.cdrivers/net/ethernet/intel/igc/igc_mac.c+21 -211 reply
9/10igc: Remove '\n' from log messages in igc_nvm.cdrivers/net/ethernet/intel/igc/igc_nvm.c+6 -61 reply
10/10igc: Remove '\n' from log strings in igc_phy.cdrivers/net/ethernet/intel/igc/igc_phy.c+26 -261 reply

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchAaron Brown
1/10T-b
2/10T-b
3/10T-b
4/10T-b
5/10T-b
6/10T-b
7/10T-b
8/10T-b
9/10T-b
10/10T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH 00/10] igc: Align log messages

Throughout IGC code we print log messages using different log helpers such as dev_*, pr_*, and netdev_*, generating inconsistent output.

Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out of the logs especially when we have more than one adapter in the system.

This patchset converts all dev_* and pr_* calls to netdev_*. There are just a few exceptions that cannot be converted because we don't have the netdev allocated yet (e.g. when the module is loaded and on PCI probe). It also takes the opportunity to improve some messages and remove the '\n' character at the end of them since is it automatically added to by netdev_* log helpers.

Regards,

Andre

Andre Guedes (10):
igc: Use netdev log helpers in igc_main.c
igc: Use netdev log helpers in igc_ethtool.c
igc: Use netdev log helpers in igc_ptp.c
igc: Use netdev log helpers in igc_dump.c
igc: Use netdev log helpers in igc_base.c
igc: Use netdev log helpers in igc_diag.c
igc: Remove '\n' from log strings in igc_i225.c
igc: Remove '\n' from log strings in igc_mac.c
igc: Remove '\n' from log messages in igc_nvm.c
igc: Remove '\n' from log strings in igc_phy.c

 drivers/net/ethernet/intel/igc/igc_base.c    |  16 +--
 drivers/net/ethernet/intel/igc/igc_diag.c    |  22 ++--
 drivers/net/ethernet/intel/igc/igc_dump.c    | 109 ++++++++--------
 drivers/net/ethernet/intel/igc/igc_ethtool.c |  48 ++++---
 drivers/net/ethernet/intel/igc/igc_i225.c    |  22 ++--
 drivers/net/ethernet/intel/igc/igc_mac.c     |  42 +++---
 drivers/net/ethernet/intel/igc/igc_main.c    | 129 +++++++++----------
 drivers/net/ethernet/intel/igc/igc_nvm.c     |  12 +-
 drivers/net/ethernet/intel/igc/igc_phy.c     |  52 ++++----
 drivers/net/ethernet/intel/igc/igc_ptp.c     |  12 +-
 10 files changed, 223 insertions(+), 241 deletions(-)
Signature · 1 line
2.25.0