Skip to content

xfs: various fixes and cleanups

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8xfs: Lower CIL flush limit for large logsfs/xfs/xfs_log_priv.h+23 -61 reply
2/8xfs: Throttle commits on delayed background CIL pushfs/xfs/xfs_log_cil.c fs/xfs/xfs_log_priv.h fs/xfs/xfs_trace.h+58 -45 replies
3/8xfs: don't allow log IO to be throttledfs/xfs/xfs_log.c+9 -11 reply
4/8xfs: Improve metadata buffer reclaim accountabilityfs/xfs/xfs_buf.c+8 -33 replies
5/8xfs: correctly acount for reclaimable slabsfs/xfs/xfs_super.c+2 -11 reply
6/8xfs: factor common AIL item deletion codefs/xfs/xfs_inode_item.c fs/xfs/xfs_trans_ail.c fs/xfs/xfs_trans_priv.h+30 -344 replies
7/8xfs: tail updates only need to occur when LSN changesfs/xfs/xfs_inode_item.c fs/xfs/xfs_trans_ail.c fs/xfs/xfs_trans_priv.h+51 -232 replies
8/8xfs: factor inode lookup from xfs_ifree_clusterfs/xfs/xfs_inode.c+84 -681 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchBrian FosterChristoph HellwigDarrick J. WongAllison Collins
1/8R-b R-b R-b
2/8R-b R-b R-b
3/8R-b R-b R-b R-b
4/8R-b R-b
5/8R-b R-b R-b
6/8R-b R-b R-b R-b
7/8R-b R-b R-b R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] xfs: various fixes and cleanups

Hi folks,

These are the fixes and cleanups that are part of the non-blocking inode reclaim series I've (slowly) been working on. These fixes and cleanups stand alone, many have already been reviewed, and getting them out of the non-blocking reclaim patchset makes that a much smaller and easier to digest set of patches.

The changes in this patchset are for:

- limiting the size of checkpoints that the CIL builds to reduce the memory it pins and the latency of commits.
- cleaning up the AIL item removal code so we can reduce the number of tail LSN updates to prevent unnecessary thundering herd wakeups
- account for reclaimable slab caches in XFS correctly
- account for reclaimed pages from buffers correctly
- avoiding log IO priority inversions
- factoring the inode cluster deletion code to make it more readable and easier to modify for the non-blocking inode reclaim mods.

Thoughts, comments and improvemnts welcome.

-Dave.

Dave Chinner (8):
xfs: Lower CIL flush limit for large logs
xfs: Throttle commits on delayed background CIL push
xfs: don't allow log IO to be throttled
xfs: Improve metadata buffer reclaim accountability
xfs: correctly acount for reclaimable slabs
xfs: factor common AIL item deletion code
xfs: tail updates only need to occur when LSN changes
xfs: factor inode lookup from xfs_ifree_cluster

 fs/xfs/xfs_buf.c        |  11 ++-
 fs/xfs/xfs_inode.c      | 152 ++++++++++++++++++++++------------------
 fs/xfs/xfs_inode_item.c |  28 ++++----
 fs/xfs/xfs_log.c        |  10 ++-
 fs/xfs/xfs_log_cil.c    |  37 ++++++++--
 fs/xfs/xfs_log_priv.h   |  53 ++++++++++++--
 fs/xfs/xfs_super.c      |   3 +-
 fs/xfs/xfs_trace.h      |   1 +
 fs/xfs/xfs_trans_ail.c  |  88 ++++++++++++++---------
 fs/xfs/xfs_trans_priv.h |   6 +-
 10 files changed, 257 insertions(+), 132 deletions(-)
Signature · 1 line
2.26.0.rc2