Skip to content

mirror: Fix hang (operation waiting for itself/circular dependency)

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Mark active mirror operations as in-flight, too

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "mirror: Don't let an operation wait for itself"block/mirror.c+9 -120 replies
2/2mirror: Wait only for in-flight operationsblock/mirror.c+8 -11 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakeMax Reitz
SeriesR-b
1/2
2/2Functionally-reviewed-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] mirror: Fix hang (operation waiting for itself/circular dependency)

The recent fix didn't actually fix the whole problem. Operations can't only wait for themselves, but we can also end up with circular dependencies like two operations waiting for each other to complete.

This reverts the first fix and implements another approach.

v2:
- Mark active mirror operations as in-flight, too

Kevin Wolf (2):
Revert "mirror: Don't let an operation wait for itself"
mirror: Wait only for in-flight operations

 block/mirror.c | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)
Signature · 1 line
2.20.1