Skip to content

Improvements for Case-insensitive handling

Gabriel Krisman Bertazi linux-ext4 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11tune2fs: Allow enabling casefold feature after fs creationmisc/tune2fs.c+15 -10 replies
2/11tune2fs: Fix casefold+encrypt error messagemisc/tune2fs.c+1 -10 replies
3/11ext2fs: Add method to validate casefolded stringslib/ext2fs/ext2fs.h lib/ext2fs/ext2fsP.h lib/ext2fs/nls_utf8.c+40 -00 replies
4/11ext2fs: Implement faster CI comparison of stringslib/ext2fs/ext2fs.h lib/ext2fs/ext2fsP.h lib/ext2fs/nls_utf8.c+41 -00 replies
5/11e2fsck: Fix entries with invalid encoded characterse2fsck/e2fsck.c e2fsck/e2fsck.h e2fsck/pass1.c +1 more+64 -10 replies
6/11e2fsck: Support casefold directories when rehashinge2fsck/rehash.c+72 -160 replies
7/11dict: Support comparison with contexte2fsck/pass1b.c e2fsck/pass2.c lib/support/dict.c +2 more+22 -100 replies
8/11e2fsck: Detect duplicated casefolded direntries for rehashe2fsck/pass2.c+21 -10 replies
9/11e2fsck: Add option to force encoded filename verificatione2fsck/e2fsck.h e2fsck/pass2.c e2fsck/unix.c+8 -20 replies
10/11e2fsck.8.in: Document check_encoding extended optione2fsck/e2fsck.8.in+4 -00 replies
11/11tests: f_bad_fname: Test fixes of invalid filenames and duplicatestests/f_bad_fname/expect.1 tests/f_bad_fname/expect.2 tests/f_bad_fname/image.gz +1 more+30 -00 replies
11/11tests: f_bad_fname: Validate fix of invalid filenames and duplicatestests/f_bad_fname/expect.1 tests/f_bad_fname/expect.2 tests/f_bad_fname/image.gz +1 more+30 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH e2fsprogs 00/11] Improvements for Case-insensitive handling

Hi,

This patchset introduces my lastest improvements to handling casefolded directories in e2fsprogs. It is split in 3 parts:

Patch 1 and 2 provide tune2fs with the capability to enable the CASEFOLD feature on existing filesystems. The reasoning why this was not the default since ever, and why it is safe to do so now, is on the commit message.

Patch 3 and 4 implement some NLS/UTF-8 methods important to the fsck validations done after.

Patch 5 and higher, improve e2fsck to fix the following issues in case-insensitive directories: badly encoded filenames, duplicated filenames, differing only by case.

The final patches also introduce documentation to the new functionalities and tests for the new fsck features.

This series was tested agains the e2fsprogs testsuite and didn't trigger any regressions.

Gabriel Krisman Bertazi (11):
tune2fs: Allow enabling casefold feature after fs creation
tune2fs: Fix casefold+encrypt error message
ext2fs: Add method to validate casefolded strings
ext2fs: Implement faster CI comparison of strings
e2fsck: Fix entries with invalid encoded characters
e2fsck: Support casefold directories when rehashing
dict: Support comparison with context
e2fsck: Detect duplicated casefolded direntries for rehash
e2fsck: Add option to force encoded filename verification e2fsck.8.in: Document check_encoding extended option
tests: f_bad_fname: Validate fix of invalid filenames and duplicates

 e2fsck/e2fsck.8.in         |   4 ++
 e2fsck/e2fsck.c            |   4 ++
 e2fsck/e2fsck.h            |   2 +
 e2fsck/pass1.c             |  17 +++++++
 e2fsck/pass1b.c            |   2 +-
 e2fsck/pass2.c             |  68 ++++++++++++++++++++++++++--
 e2fsck/rehash.c            |  88 ++++++++++++++++++++++++++++++-------
 e2fsck/unix.c              |   4 ++
 lib/ext2fs/ext2fs.h        |   6 +++
 lib/ext2fs/ext2fsP.h       |   6 +++
 lib/ext2fs/nls_utf8.c      |  69 +++++++++++++++++++++++++++++
 lib/support/dict.c         |  22 +++++++---
 lib/support/dict.h         |   4 +-
 lib/support/mkquota.c      |   2 +-
 misc/tune2fs.c             |  18 +++++++-
 tests/f_bad_fname/expect.1 |  22 ++++++++++
 tests/f_bad_fname/expect.2 |   7 +++
 tests/f_bad_fname/image.gz | Bin 0 -> 802 bytes
 tests/f_bad_fname/name     |   1 +
 19 files changed, 316 insertions(+), 30 deletions(-)
 create mode 100644 tests/f_bad_fname/expect.1
 create mode 100644 tests/f_bad_fname/expect.2
 create mode 100644 tests/f_bad_fname/image.gz
 create mode 100644 tests/f_bad_fname/name
Signature · 1 line
2.25.0