Skip to content

media: staging: rkisp1: Fix formats for metadata pads

Dafna Hirschfeld linux-media linux-rockchip 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: media.h: Add a pad flag MEDIA_PAD_FL_METADATADocumentation/media/uapi/mediactl/media-types.rst include/uapi/linux/media.h+5 -06 replies
2/2media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the metadata padsdrivers/staging/media/rkisp1/TODO drivers/staging/media/rkisp1/rkisp1-isp.c drivers/staging/media/rkisp1/rkisp1-params.c +1 more+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] media: staging: rkisp1: Fix formats for metadata pads

There are 4 pads between the entities
rkisp1_isp, rkisp1_params, rkisp1_stats that transmit metadata. Since metadata has no dimensions, it makes sense to set the width and height of these pads to 0. The problem is that it makes the v4l-compliance tests fail. Currently, in order to silent the tests, the width and height are set to RKISP1_DEFAULT_*

This patchset sets the dimensions to 0 and solves the compliance error by introducing a new flag MEDIA_PAD_FL_METADATA in media.h and setting this flag to those pads.
Then the v4l2-compliance tests can skip the dimensions test if this flag is set.

This is just a suggested implementation from Laurent, a better documentation is probably needed.
Another possible solution suggested by Verkuil
is to add a new media bus format: MEDIA_BUS_FMT_FIXED_METADATA.

- patch 1: introduces the the flag
- patch 2: set the flag to the pads and removes a related TODO item

A corresponding patch to v4l-utils will be sent.

Dafna Hirschfeld (2):
media: media.h: Add a pad flag MEDIA_PAD_FL_METADATA
media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the
metadata pads

 Documentation/media/uapi/mediactl/media-types.rst |  4 ++++
 drivers/staging/media/rkisp1/TODO                 |  1 -
 drivers/staging/media/rkisp1/rkisp1-isp.c         | 10 ++++++----
 drivers/staging/media/rkisp1/rkisp1-params.c      |  2 +-
 drivers/staging/media/rkisp1/rkisp1-stats.c       |  2 +-
 include/uapi/linux/media.h                        |  1 +
 6 files changed, 13 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.1