Skip to content

media: staging: rkisp1: cap: various fixes for capture formats

Dafna Hirschfeld linux-media linux-rockchip 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesNew
  2. v36 patches 4 repliesSuperseded
  3. v25 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches4 repliesSuperseded

Changes in v4 from the cover letter

- In patch 5 in the doc and log message: s/plane formats/planar formats/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6media: staging: rkisp1: cap: cleanup in mainpath config for uv swap formatdrivers/staging/media/rkisp1/rkisp1-capture.c+1 -20 replies
2/6media: staging: rkisp1: cap: fix value written to uv swap register in selfpathdrivers/staging/media/rkisp1/rkisp1-capture.c+2 -20 replies
3/6media: staging: rkisp1: cap: change the logic for writing to uv swap registerdrivers/staging/media/rkisp1/rkisp1-capture.c+11 -100 replies
4/6media: staging: rkisp1: cap: support uv swap only for semiplanar formatsdrivers/staging/media/rkisp1/rkisp1-capture.c+19 -120 replies
5/6media: staging: rkisp1: cap: support uv swapped planar formatsdrivers/staging/media/rkisp1/rkisp1-capture.c+8 -00 replies
6/6media: staging: rkisp1: cap: remove unsupported formatsdrivers/staging/media/rkisp1/rkisp1-capture.c+0 -170 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchHelen KoikeLaurent Pinchart
1/6A-b R-b
2/6A-b
3/6R-b
4/6R-b
5/6R-b
6/6A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] media: staging: rkisp1: cap: various fixes for capture formats

This patchset fixes various issues related to
the supported formats in the rkisp1 capture.

This patchset is rebased on top of v3 of the patchset:
"rkisp1: use enum v4l2_pixel_encoding instead of rkisp1_fmt_pix_type"

Patches summary:

patches 1,2 - fixes a wrong assignments to the register that swaps the 'u', 'v' planes in YUV semiplanar formats.

patch 3 - writes to the uv swap with "off" if swapping is not needed.

patch 4 - sets the uv swap register only if the format is semiplanar.

patch 5 - adds support to planar YUV formats with swapped u,v planes by swapping the addresses of the planes

patch 6 - removes some packed YUV formats that are not supported by the driver.

changes from v1:
- split the first patch from v1 into two separate patches, the first is a cleanup patch the second fixes a bug.

changes from v2:
- rebasing the patchset on top of v3 of
"rkisp1: use enum v4l2_pixel_encoding instead of rkisp1_fmt_pix_type"
- patches 1,2: replace "reg = reg | .." with "reg |= .."
- adding patch 3 to change the logic of wrrting to uv swap reg
- patches 4,5: checking if format is (semi)planar using the info pointer and not using the write_format value
- patch 4: using the "swap" define to swap the cb, cr addresses

changes from v3:
- In patch 5 in the doc and log message: s/plane formats/planar formats/

Dafna Hirschfeld (6):
media: staging: rkisp1: cap: cleanup in mainpath config for uv swap
format
media: staging: rkisp1: cap: fix value written to uv swap register in
selfpath
media: staging: rkisp1: cap: change the logic for writing to uv swap
register
media: staging: rkisp1: cap: support uv swap only for semiplanar
formats
media: staging: rkisp1: cap: support uv swapped planar formats
media: staging: rkisp1: cap: remove unsupported formats

 drivers/staging/media/rkisp1/rkisp1-capture.c | 50 +++++++++----------
 1 file changed, 24 insertions(+), 26 deletions(-)
Signature · 1 line
2.20.1