Skip to content

Update ENA driver to v2.1.0

Michal Krawczyk dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest30 patches 5 repliesIn review
  2. v229 patches 16 repliesSuperseded
  3. v129 patches 13 repliesSuperseded

Changes in v3 from the cover letter

* Split ena_com patch for RSS into several patches
* Add entry to v20.05 release notes
* Minor fixes of the commit logs
* Update copyright date in patches doing the modifications

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30net/ena: check if size of buffer is at least 1400Bdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+13 -20 replies
2/30net/ena/base: make allocation macros thread-safedrivers/net/ena/base/ena_plat_dpdk.h drivers/net/ena/ena_ethdev.c+7 -50 replies
3/30net/ena/base: prevent allocation of 0-sized memorydrivers/net/ena/base/ena_plat_dpdk.h+17 -120 replies
4/30net/ena/base: generate default, random RSS hash keydrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_plat_dpdk.h +1 more+48 -102 replies
5/30net/ena/base: fix testing for supported hash funcdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_plat_dpdk.h+15 -60 replies
6/30net/ena/base: remove conversion of the ind tbldrivers/net/ena/base/ena_com.c+0 -280 replies
7/30net/ena/base: rework interrupt moderationdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_plat_dpdk.h+42 -2860 replies
8/30net/ena/base: remove extra properties stringsdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h+0 -890 replies
9/30net/ena/base: add accelerated LLQ modedrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_defs/ena_admin_defs.h +1 more+93 -220 replies
10/30net/ena/base: fix documentation of the functionsdrivers/net/ena/base/ena_com.h+12 -120 replies
11/30net/ena/base: fix indentation in cq pollingdrivers/net/ena/base/ena_com.c+4 -40 replies
12/30net/ena/base: add error logs when preparing Txdrivers/net/ena/base/ena_eth_com.c+19 -50 replies
13/30net/ena/base: use 48-bit memory addresses in ena_comdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_defs/ena_common_defs.h+7 -30 replies
14/30net/ena/base: fix types for printing timestampsdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_plat_dpdk.h+3 -10 replies
15/30net/ena/base: fix indentation of multiple definesdrivers/net/ena/base/ena_com.h+4 -40 replies
16/30net/ena/base: update gen date and commitdrivers/net/ena/base/ena_defs/ena_gen_info.h+3 -30 replies
17/30net/ena: set IO ring size to the valid valuedrivers/net/ena/ena_ethdev.c+1 -20 replies
18/30net/ena: refactor getting IO queues capabilitiesdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+52 -600 replies
19/30net/ena: add support for large LLQ headersdoc/guides/nics/ena.rst doc/guides/rel_notes/release_20_05.rst drivers/net/ena/ena_ethdev.c +1 more+121 -70 replies
20/30net/ena: remove memory barriers before doorbellsdrivers/net/ena/ena_ethdev.c+1 -80 replies
21/30net/ena: add Tx drops statisticdoc/guides/rel_notes/release_20_05.rst drivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+16 -40 replies
22/30net/ena: disable meta cachingdoc/guides/rel_notes/release_20_05.rst drivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+25 -60 replies
23/30net/ena: refactor Rx pathdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+124 -660 replies
24/30net/ena: rework getting number of available descsdrivers/net/ena/ena_ethdev.c+13 -120 replies
25/30net/ena: limit refill threshold by fixed valuedrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+24 -130 replies
26/30net/ena: use macros for ring idx operationsdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+30 -270 replies
27/30net/ena: refactor Tx pathdrivers/net/ena/ena_ethdev.c+179 -1440 replies
28/30net/ena: reuse 0 length Rx descriptordoc/guides/rel_notes/release_20_05.rst drivers/net/ena/ena_ethdev.c+61 -150 replies
29/30doc: add notes on ENA usage on metal instancesdoc/guides/nics/ena.rst+46 -20 replies
30/30net/ena: update version of the driver to v2.1.0drivers/net/ena/ena_ethdev.c+2 -20 replies

Reviews trailers per patch

28 of 30 patches have a Reviewed-by or Acked-by.

PatchIgor ChauskinGuy TzalikMichal Krawczyk
1/30R-b R-b
2/30R-b R-b
3/30R-b R-b
4/30R-b R-b
5/30
6/30
7/30R-b R-b
8/30R-b R-b
9/30R-b R-b
10/30R-b R-b
11/30R-b R-b
12/30R-b R-b
13/30R-b R-b
14/30R-b R-b
15/30R-b R-b
16/30R-b R-b
17/30R-b R-b
18/30R-b R-b
19/30R-b R-b
20/30R-b R-b
21/30R-b R-b
22/30R-b R-b
23/30R-b R-b
24/30R-b R-b
25/30R-b R-b
26/30R-b R-b
27/30R-b R-b
28/30R-b R-b
29/30R-b R-b
30/30R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

Hi,

This patchset is including severeal changes, including:
* ena_com (HAL) update
* Support for upcoming device features
* Refactor of the IO path
* Documentation update about ENA usage on metal instances

v2:
* Fix comments from review

v3:
* Split ena_com patch for RSS into several patches
* Add entry to v20.05 release notes
* Minor fixes of the commit logs
* Update copyright date in patches doing the modifications

Igor Chauskin (2):
net/ena/base: make allocation macros thread-safe net/ena/base: prevent allocation of 0-sized memory

Michal Krawczyk (28):
net/ena: check if size of buffer is at least 1400B net/ena/base: generate default, random RSS hash key net/ena/base: fix testing for supported hash func net/ena/base: remove unnecessary conversion of the ind tbl net/ena/base: rework interrupt moderation net/ena/base: remove extra properties strings net/ena/base: add accelerated LLQ mode net/ena/base: fix documentation of the functions net/ena/base: fix indentation in cq polling net/ena/base: add error logs when preparing Tx net/ena/base: use 48-bit memory addresses in ena_com net/ena/base: fix types for printing timestamps net/ena/base: fix indentation of multiple defines net/ena/base: update gen date and commit net/ena: set IO ring size to the valid value net/ena: refactor getting IO queues capabilities net/ena: add support for large LLQ headers net/ena: remove memory barriers before doorbells net/ena: add Tx drops statistic
net/ena: disable meta caching
net/ena: refactor Rx path
net/ena: rework getting number of available descs net/ena: limit refill threshold by fixed value net/ena: use macros for ring idx operations net/ena: refactor Tx path
net/ena: reuse 0 length Rx descriptor
doc: add notes on ENA usage on metal instances net/ena: update version of the driver to v2.1.0

 doc/guides/nics/ena.rst                       |  58 +-
 doc/guides/rel_notes/release_20_05.rst        |   9 +
 drivers/net/ena/base/ena_com.c                | 340 ++-----
 drivers/net/ena/base/ena_com.h                | 223 +----
 .../net/ena/base/ena_defs/ena_admin_defs.h    |  41 +-
 .../net/ena/base/ena_defs/ena_common_defs.h   |   8 +-
 drivers/net/ena/base/ena_defs/ena_gen_info.h  |   6 +-
 drivers/net/ena/base/ena_eth_com.c            |  75 +-
 drivers/net/ena/base/ena_plat_dpdk.h          |  48 +-
 drivers/net/ena/ena_ethdev.c                  | 902 +++++++++++-------
 drivers/net/ena/ena_ethdev.h                  |  48 +-
 11 files changed, 940 insertions(+), 818 deletions(-)
Signature · 1 line
2.20.1