Skip to content

ARM: simplify handover from UEFI to decompressor

Ard Biesheuvel linux-arm-kernel linux-efi 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 0 repliesNew
  2. v35 patches 0 repliesSuperseded
  3. v25 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches4 repliesSuperseded

Changes in v4 from the cover letter

- rebase onto rmk/for-next with Geert's DT memory node patch [0] removed, as it has been reverted again due to regressions

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ARM: decompressor: move headroom variable out of LC0arch/arm/boot/compressed/head.S+4 -20 replies
2/5ARM: decompressor: split off _edata and stack base into separate objectarch/arm/boot/compressed/head.S+12 -110 replies
3/5ARM: decompressor: defer loading of the contents of the LC0 structurearch/arm/boot/compressed/head.S+4 -110 replies
4/5ARM: decompressor: move GOT into .data for EFI enabled buildsarch/arm/boot/compressed/vmlinux.lds.S+5 -00 replies
5/5ARM: decompressor: run decompressor in place if loaded via UEFIarch/arm/boot/compressed/head.S drivers/firmware/efi/libstub/arm32-stub.c+20 -640 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchGeert UytterhoevenNicolas Pitre
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] ARM: simplify handover from UEFI to decompressor

The EFI stub in the ARM kernel runs in the context of the firmware, which means it usually runs with the caches and MMU on. Currently, we relocate the zImage so it appears in the first 128 MiB, disable the MMU and caches and invoke the decompressor via its ordinary entry point. However, since we can pass the base of DRAM directly, there is no need to relocate the zImage, which also means there is no need to disable and re-enable the caches and create new page tables etc.

This simplification is implemented by patch #5. Patches #1 - #4 are prerequisite changes to permit the decompressor startup code to be invoked past its ordinary entry point, and execute from the offset where the UEFI firmware happened to load it.

Note that this applies onto rmk/for-next as of today.

Changes since v3:
- rebase onto rmk/for-next with Geert's DT memory node patch [0] removed, as it has been reverted again due to regressions

Changes since v2:
- Set the LSB of the image address if we are entering with MMU and caches off, so that the decompressor will install its own page tables as it usually does. This might happen on U-Boot platforms that call 'bootefi' without enabling the caches (which technically violates the UEFI spec, but might be working fine today)
- Add Nico's ack to the series

Changes since v1:
- Tweak some asm sequences in #2 to fix the Thumb2 build
- Switch immediately to the new stack in #5

Cc Geert Uytterhoeven <[email protected]>
Cc Nicolas Pitre <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Russell King <[email protected]>
Cc Heinrich Schuchardt <[email protected]>

[0] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Ard Biesheuvel (5):
ARM: decompressor: move headroom variable out of LC0
ARM: decompressor: split off _edata and stack base into separate
object
ARM: decompressor: defer loading of the contents of the LC0 structure
ARM: decompressor: move GOT into .data for EFI enabled builds
ARM: decompressor: run decompressor in place if loaded via UEFI

 arch/arm/boot/compressed/head.S           | 79 ++++++++------------
 arch/arm/boot/compressed/vmlinux.lds.S    |  5 ++
 drivers/firmware/efi/libstub/arm32-stub.c | 45 ++---------
 3 files changed, 43 insertions(+), 86 deletions(-)
Signature · 1 line
2.17.1